| 2009-09-05 00:35:06 |
Craig Macomber |
description |
As discussed and verified http://www.panda3d.org/phpbb2/viewtopic.php?p=44052
When a window has non power of 2 dimensions, filters such as the bloom filter appear to sample from an uninitialized section of the texture beyond the top and/or right edges of the windows.
Initially found on a mac with a Nvidia GeForce 9600m GT. Related issue found by FenrirWolf on Windows, Nvidia 6800 Ultra.
I suspect it has to do with both the bloom shader and the resizing shader sampling outside of the screen region of the texture. This is possible related to a lack of padding being specified in CommonFilters.py, or likely could be resolved by modifying the shaders in question to specially handle the top and right screen edges. |
As discussed and verified http://www.panda3d.org/phpbb2/viewtopic.php?p=44052
When a window has non power of 2 dimensions, filters such as the bloom filter appear to sample from an uninitialized section of the texture beyond the top and/or right edges of the windows.
Initially found on a mac with a Nvidia GeForce 9600m GT. Related issue found by FenrirWolf on Windows, Nvidia 6800 Ultra.
I suspect it has to do with both the bloom shader and the resizing shader sampling outside of the screen region of the texture. This is possible related to a lack of padding being specified in CommonFilters.py, or likely could be resolved by modifying the shaders in question to specially handle the top and right screen edges.
Found with the released 1.6.2 version of panda. |
|
| 2009-09-09 05:40:27 |
Craig Macomber |
description |
As discussed and verified http://www.panda3d.org/phpbb2/viewtopic.php?p=44052
When a window has non power of 2 dimensions, filters such as the bloom filter appear to sample from an uninitialized section of the texture beyond the top and/or right edges of the windows.
Initially found on a mac with a Nvidia GeForce 9600m GT. Related issue found by FenrirWolf on Windows, Nvidia 6800 Ultra.
I suspect it has to do with both the bloom shader and the resizing shader sampling outside of the screen region of the texture. This is possible related to a lack of padding being specified in CommonFilters.py, or likely could be resolved by modifying the shaders in question to specially handle the top and right screen edges.
Found with the released 1.6.2 version of panda. |
As discussed and verified http://www.panda3d.org/phpbb2/viewtopic.php?p=44052
When a window has non power of 2 dimensions, filters such as the bloom filter appear to sample from an uninitialized section of the texture beyond the top and/or right edges of the windows.
Initially found on a mac with a Nvidia GeForce 9600m GT. Related issue found by FenrirWolf on Windows, Nvidia 6800 Ultra.
I suspect it has to do with both the bloom shader and the resizing shader sampling outside of the screen region of the texture. This is possible related to a lack of padding being specified in CommonFilters.py, or likely could be resolved by modifying the shaders in question to specially handle the top and right screen edges.
Fix for the filter-bloomx.sha file:
added the clamps to these 3 lines:
l_texcoord0 = clamp(float4(c.x-offset* -4, c.x-offset* -3, c.x-offset* -2, c.y), 0, 2*texpad_src.xxxy);
l_texcoord1 = clamp(float4(c.x-offset* -1, c.x-offset* 0, c.x-offset* 1, c.y), 0, 2*texpad_src.xxxy);
l_texcoord2 = clamp(float4(c.x-offset* 2, c.x-offset* 3, c.x-offset* 4, c.y), 0, 2*texpad_src.xxxy);
tried to fix bloom y the same way, and failed.
Found with the released 1.6.2 version of panda.
Workaround:
In prc file: "textures-power-2 none"
|
|
