shader inputs cant have _ in the name

Bug #293479 reported by Treeform
2
Affects Status Importance Assigned to Milestone
Panda3D
Fix Released
Low
rdb

Bug Description

in function cp_errchk_parameter_words line 75 in shaderContext.cxx

it checks for _ and and says parameter name has wrong number of words

Revision history for this message
rdb (rdb) wrote :

Fixed. k-parameters can now have underscores in the name.

Changed in panda3d:
assignee: nobody → niertie1
importance: Undecided → Low
milestone: none → 1.6.0
status: New → Fix Committed
Revision history for this message
Treeform (starplant) wrote : Re: [Bug 293479] Re: shader inputs cant have _ in the name

I don't think this is a simple case? Did you check if it does not
barf any place down the line? Maybe we should come up with some sort
automated shader tests to run?

On Sat, Jan 31, 2009 at 9:44 AM, pro-rsoft <email address hidden> wrote:
> Fixed. k-parameters can now have underscores in the name.
>
> ** Changed in: panda3d
> Importance: Undecided => Low
> Assignee: (unassigned) => pro-rsoft (niertie1)
> Status: New => Fix Committed
> Target: None => 1.6.0
>
> --
> shader inputs cant have _ in the name
> https://bugs.launchpad.net/bugs/293479
> You received this bug notification because you are a direct subscriber
> of the bug.
>

Revision history for this message
rdb (rdb) wrote :

No, there's some code that tokenizes the parameter (with _ as delimiter),
then with 'if'-statements checks the first word. If it's "k", I made it not
to tokenize the rest. So it's really this simple.

rdb (rdb)
Changed in panda3d:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers