DirectRadioButton--removal of model-loading by default and indicator handling
Bug #1381595 reported by
alan eborn
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Panda3D |
Fix Released
|
Undecided
|
rdb | ||
Bug Description
* The "boxImage" constructor keyword is now by default "None", instead of an automatically-
* If no "boxImage" is specified, DirectRadioButton now defaults to a basic sunken frame.
Please see the attachment for the patch.
Revision history for this message
| alan eborn (a-eborn) wrote | #1 |
| Changed in panda3d: | |
| assignee: | nobody → rdb (rdb) |
| milestone: | none → 1.9.0 |
| status: | New → Fix Committed |
| Changed in panda3d: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
But I think it's a really, really bad idea for an API to subtly change the semantics of one option based on a particular combination of other options. This just makes it unpredictable. The only reason I am (somewhat reluctantly) checking in the DGG.RAISED change is because it feels like a good replacement for the old image.
In particular, the boxGeom parameter served exactly the purpose of replacing both the indicator and its background image. Let's keep it for that purpose, and not start fiddling with indicator texts and positions when the user could just as easily pass whatever he passes to boxImage to boxGeom instead.
Checked in:
https:/
Thanks!