DirectDialog--removal of model-loading by default and a bug-fix

Bug #1381593 reported by alan eborn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Panda3D
Fix Released
Undecided
rdb

Bug Description

 * The backdrop is now by default a basic grey frame if relief is set to "DGG.FLAT" and invisible otherwise, instead of a model loaded automatically.

        - The Panda-provided model can still be loaded by setting the dialogue's "image" constructor keyword to "DGG.getDefaultDialogGeom()".

        - To my mind, while arguably unappealing, the grey frame is at least in keeping with the rest of DirectGUI's default appearance.

 * Code has been added to catch two places in which calls to "getTightBounds" may return "None", potentially tripping up the construction of the dialogue.

 * The Panda-provided dialogues ("Yes-No", "Retry-Cancel", etc.) now by default show with a flat grey frame.

Please see the attachment for the patch.

Revision history for this message
alan eborn (a-eborn) wrote :
Revision history for this message
rdb (rdb) wrote :

Committed with changes.
https://github.com/panda3d/panda3d/commit/2e555db30e1eb215e1ecf605975220b0e6e31abc

* Changing the value of fadeScreen seems unnecessary.
* The image had a relief. Let's at least keep the relief by default rather than use a flat plane.
* The original image was automatically rescaled so that it fit around the buttons. In your patch, the frame was only adjusted to fit around the text, but for small texts this wouldn't be large enough to go around the buttons. This was trivial to change.

Changed in panda3d:
assignee: nobody → rdb (rdb)
milestone: none → 1.9.0
rdb (rdb)
Changed in panda3d:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers