Fix some warning

Bug #1024134 reported by Yvon TANGUY on 2012-07-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Panda3D
Undecided
Unassigned

Bug Description

I have fix some random warning, during a boring raining day...

It include some of theses warnings:
Wmissing_braces
Wreturn_type
Wsign_compare
Wuninitialized
Wunused

It compile, so it's perfect !

OS: Ubuntu GNU/Linux 12.04 64bits
Panda3D: CVS Head (main?) 1.8.0+

Note for after: there is a ugly thing to fix in the Pyhon glue code:
panda3d/built/include/py_panda.h:172:55: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]

But for me it is a mess out there, I do not understand the code enough to clean it.

Yvon TANGUY (vono22) wrote :
Josh Enes (joshenes) wrote :

Some of these changes look dangerous, fixing warnings simply by commenting lines out.
It might be worth reviewing the patch, but carefully.

rdb (rdb) wrote :

Most of the lines he commented out were unused variables. Still, there's a lot in there I'm not sure about, and things that would probably break other systems. I'll look into it when I have the time, but to be honest it's not high on my todo list.

rdb (rdb) on 2016-07-14
Changed in panda3d:
milestone: none → 1.10.0
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers