Remove runtime dependency on setuptools

Bug #1713950 reported by Javier Peña
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Packstack
Fix Released
Undecided
Unassigned

Bug Description

In general, setuptools should be used to build and distribute Python packages. We're also using pkg_resources.py in [1] to locate the documentation and use it inside Packstack, which is not the best idea and breaks some Fedora packaging guidelines [2].

[1] https://github.com/openstack/packstack/blob/master/packstack/installer/basedefs.py#L32-L34
[2] Files located in %_pkgdocdir must not affect the runtime of the packaged software

Revision history for this message
Javier Peña (jpena-c) wrote :
Revision history for this message
Javier Peña (jpena-c) wrote :

Actually, the RDO packaging is correct, because the file is moved to /usr/share/packstack.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to packstack (master)

Reviewed: https://review.openstack.org/500488
Committed: https://git.openstack.org/cgit/openstack/packstack/commit/?id=1948987952a2cedc055d03a7a6ba5affd701bd4d
Submitter: Jenkins
Branch: master

commit 1948987952a2cedc055d03a7a6ba5affd701bd4d
Author: Javier Pena <email address hidden>
Date: Mon Sep 4 11:12:40 2017 +0200

    Remove runtime dependency on setuptools

    We were only depending on setuptools for runtime to use pkg_resources,
    so we could fetch the path to the rst documentation in certain cases
    (mainly during development). We can figure out that path using
    other means, so we do not depend on setuptools anymore.

    Closes-Bug: #1713950
    Change-Id: I9c0f676ac2219001118f7191a6e5c8faee3312c4

Changed in packstack:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to packstack (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/513039

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to packstack (stable/pike)

Reviewed: https://review.openstack.org/513039
Committed: https://git.openstack.org/cgit/openstack/packstack/commit/?id=f69cabfa52f020ddccf6a4afe579064e993b81a8
Submitter: Zuul
Branch: stable/pike

commit f69cabfa52f020ddccf6a4afe579064e993b81a8
Author: Javier Pena <email address hidden>
Date: Mon Sep 4 11:12:40 2017 +0200

    Remove runtime dependency on setuptools

    We were only depending on setuptools for runtime to use pkg_resources,
    so we could fetch the path to the rst documentation in certain cases
    (mainly during development). We can figure out that path using
    other means, so we do not depend on setuptools anymore.

    Closes-Bug: #1713950
    Change-Id: I9c0f676ac2219001118f7191a6e5c8faee3312c4
    (cherry picked from commit 1948987952a2cedc055d03a7a6ba5affd701bd4d)

tags: added: in-stable-pike
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.