Support Puppet4

[Alan Pevec]

Copied from https://bugzilla.redhat.com/show_bug.cgi?id=1349695

Summary: Incorrect Format for 'mode' in Puppet Manifest amqp.pp

Description of problem:
packstack installer fails with the error
ERROR : Error appeared during Puppet run: 192.168.30.20_amqp.pp
Error: Parameter mode failed on File[rabbitmq.config]: The file mode specification must be a string, not 'Fixnum' at /var/tmp/packstack/acac3c972b894b65a5f51ffa98e401a3/modules/rabbitmq/manifests/config.pp:84
You will find full trace in log /var/tmp/packstack/20160624-105930-iXVbrO/manifests/192.168.30.20_amqp.pp.log
Please check log file /var/tmp/packstack/20160624-105930-iXVbrO/openstack-setup.log for more information

Version-Release number of selected component (if applicable):
- openstack-packstack-8.0.0-1.el7.noarch
- Fedora 24 kernel 4.5.5-300.fc24.x86_64
- puppet-4.2.1-3.fc24.noarch

How reproducible:
Run the packstack installer on Fedora 24

Steps to Reproduce:
1.
2.
3.

Actual results:
ERROR : Error appeared during Puppet run: 192.168.30.20_amqp.pp

Expected results:
install should proceed w/o error

Additional info:
A similar error about string vs Fixnum in puppet manifests was reported at https://github.com/torrancew/puppet-cron/issues/41
I used this method to edit amqp.pp and now packstack installer works fine.

Here is the diff:

--- amqp.pp.orig 2016-06-24 11:09:33.996453212 +0900
+++ amqp.pp 2016-06-24 11:10:04.837401879 +0900
@@ -69,7 +69,7 @@
     ensure => present,
     owner => 'rabbitmq',
     group => 'rabbitmq',
- mode => 0640,
+ mode => '0640',
   }

 }

[Javier Peña (jpena-c)]

This is already fixed in the current Packstack master -> https://github.com/openstack/packstack/blob/master/packstack/puppet/modules/packstack/manifests/amqp.pp#L60

[Alan Pevec (apevec)]

Is this backportable to stable/mitaka?
Are there any other Puppet4 incompatiblities?

[NirLevy (nirl)]

I had the same problem.
how can I resolve it.
yum info still do not offer package later than 4.2.1

from which rpm version has this been fixed ? will it fit fedora 24?
or shall I degrade to some other package?
regards.
Nir.