Packstack should leverage PBR for setup, move OPM installation outside of setup.py

[David Moreau Simard]

Packstack doesn't use PBR right now:
https://github.com/openstack/packstack/blob/c83d29e00b1aca7adb39deb9991c84910962d180/setup.py

And it sets up OPM from source by cloning it right from the setup.py:
https://github.com/openstack/packstack/blob/c83d29e00b1aca7adb39deb9991c84910962d180/setup.py#L29-L31

We should transition to a setup.py with PBR and a setup.cfg like other projects, i.e,:
https://github.com/openstack/nova/blob/master/setup.py
https://github.com/openstack/nova/blob/master/setup.cfg

I don't feel the OPM setup should be handled by the setup.py. Perhaps instead as part of the routine that handles fetching the other dependencies .. like here for example:
https://github.com/openstack/packstack/blob/4c55410145efd2a23ff816fcdb806ae55e8b1c60/packstack/installer/basedefs.py#L85-L89
https://github.com/openstack/packstack/blob/4c55410145efd2a23ff816fcdb806ae55e8b1c60/packstack/plugins/prescript_000.py#L12446

[Ivan Chavero (imcsk8) (ichavero-ichavero)]

Shouldn't this be two bugs?

One for PBR and one for the OPM request?

[David Moreau Simard (dmsimard)]

I think both will have to be done together. Switching to PBR means scrapping the current setup.py where OPM is currently cloned.

If it can be done separately we can split the OPM part out, yes.

[Alan Pevec (apevec)]

I looked at this, both parts need to be done in the same change, once switched setup.py is fully under PBR.
prescript is the right place to clone OPM repo but I'm not sure what's the use cases for that, why don't we just always assume OPM RPM ?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/296847

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/296847
Committed: https://git.openstack.org/cgit/openstack/packstack/commit/?id=1bbcbff4fbb6dffe1f78a6e695377f30ca2e39d8
Submitter: Jenkins
Branch: master

commit 1bbcbff4fbb6dffe1f78a6e695377f30ca2e39d8
Author: Alan Pevec <email address hidden>
Date: Tue Mar 22 19:25:43 2016 +0100

    Use PBR

    Refactor setup.py using Python Build Reasonableness[1]
    as a standard for OpenStack projects.

    [1] http://docs.openstack.org/developer/pbr/

    Closes-Bug: #1559150
    Change-Id: Ie3b3845f11236f5338228690418760599914cce4