Context menu / popup menu leaks if webview is deleted

[Chris Coulson]

I'm fairly sure that deleting a webview will cause an open context menu to be leaked. I can't see anywhere that we handle cleaning up the context menu in this case.

[Olivier Tilloy (osomon)]

Isn’t the context menu a child item of the webview itself? If so the QML engine should automatically delete it when deleting the webview.

[Chris Coulson (chrisccoulson)]

The context menu is a visual child of the webview, but it's not actually owned by it

[Chris Coulson (chrisccoulson)]

Update the title to reflect that this also affects the popup menu

[Chris Coulson (chrisccoulson)]

It turns out my test for this wasn't quite right and that it does work, although it's a little obscure (the menus are deleted via WebContentsObserver::RenderFrameDeleted). I've added a test for this here - https://git.launchpad.net/oxide/commit/?id=8c7483e5fd4b9e32f94b3f1e1d560007d270e389

[Chris Coulson (chrisccoulson)]

I refactored ownership for these in subsequent commits to make it more obvious who owns them:

https://git.launchpad.net/oxide/commit/?id=d2e7bba98a03f2a2574304b7a2e60774964995c0
https://git.launchpad.net/oxide/commit/?id=7a1c29077dab786f7a482c65c181042da953b1ae