Context menu / popup menu leaks if webview is deleted

Bug #1655736 reported by Chris Coulson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Invalid
High
Unassigned

Bug Description

I'm fairly sure that deleting a webview will cause an open context menu to be leaked. I can't see anywhere that we handle cleaning up the context menu in this case.

Changed in oxide:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Olivier Tilloy (osomon) wrote :

Isn’t the context menu a child item of the webview itself? If so the QML engine should automatically delete it when deleting the webview.

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

The context menu is a visual child of the webview, but it's not actually owned by it

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Update the title to reflect that this also affects the popup menu

summary: - Context menu leaks if webview is deleted
+ Context menu / popup menu leaks if webview is deleted
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

It turns out my test for this wasn't quite right and that it does work, although it's a little obscure (the menus are deleted via WebContentsObserver::RenderFrameDeleted). I've added a test for this here - https://git.launchpad.net/oxide/commit/?id=8c7483e5fd4b9e32f94b3f1e1d560007d270e389

Changed in oxide:
status: Triaged → Invalid
Revision history for this message
Chris Coulson (chrisccoulson) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.