Fails to build because of media-hub, again

[Chris Coulson]

AILED: /usr/bin/arm-linux-gnueabihf-g++ -MMD -MF obj/oxide/shared/shared/oxide_content_renderer_client.o.d -DOXIDE_SUBPROCESS_PATH=\"oxide-qt/oxide-renderer\" -DOXIDE_GETTEXT_DOMAIN=\"oxide-qt\" -DOXIDE_SHARED_IMPLEMENTATION -DENABLE_MEDIAHUB -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PDF=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DENABLE_HYBRIS -DENABLE_HYBRIS_CAMERA -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DOXIDE_BUILD -DOXIDE_BUILD -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DOXIDE_BUILD -DV8_USE_EXTERNAL_STARTUP_DATA -DOPUS_FIXED_POINT -DMESA_EGL_NO_X11_HEADERS -I../.. -Igen -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include -I../../oxide -Igen/oxide -I../../third_party/khronos -I../../gpu -I../../third_party/libwebp -I../../third_party/re2/src -Igen/oxide/shared -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/libwebm/source -I../../third_party/opus/src/include -I../../third_party/boringssl/src/include -I/usr/include/nss -I/usr/include/nspr -Igen -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen/v8/include -I../../v8/include -Igen/v8/include -I../../third_party/mesa/src/include -I../../third_party/ffmpeg/chromium/config/Chrome/linux/arm-neon -I../../third_party/ffmpeg -I/usr/include/dbus-1.0 -I/usr/lib/arm-linux-gnueabihf/dbus-1.0/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -pthread -march=armv7-a -mfloat-abi=hard -mtune=generic-armv7-a -mfpu=neon -mthumb -Wall -Wno-psabi -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -g1 -fvisibility=hidden -fno-threadsafe-statics -fvisibility-inlines-hidden -fno-delete-null-pointer-checks -std=gnu++11 -Wno-narrowing -fno-rtti -fno-exceptions -c ../../oxide/shared/renderer/oxide_content_renderer_client.cc -o obj/oxide/shared/shared/oxide_content_renderer_client.o
In file included from ../../oxide/shared/renderer/oxide_content_renderer_client.cc:53:0:
../../oxide/shared/renderer/media/oxide_web_media_player.h:170:8: error: conflicting return type specified for ‘virtual void oxide::WebMediaPlayer::OnSuspendRequested(bool)’
   void OnSuspendRequested(bool must_suspend) override;
        ^
In file included from ../../oxide/shared/renderer/media/oxide_web_media_player.h:21:0,
                 from ../../oxide/shared/renderer/oxide_content_renderer_client.cc:53:
../../media/blink/webmediaplayer_delegate.h:37:18: error: overriding ‘virtual bool media::WebMediaPlayerDelegate::Observer::OnSuspendRequested(bool)’
     virtual bool OnSuspendRequested(bool must_suspend) = 0;
                  ^
ninja: build stopped: subcommand failed.

[David Barth (dbarth)]

Can't this integration become a dlopen that just fails (gracefully, at
runtime) if ever media-hub messes up symbols again ?

On Thu, Nov 24, 2016 at 9:28 AM, Chris Coulson <email address hidden>
wrote:

> Public bug reported:
>
> AILED: /usr/bin/arm-linux-gnueabihf-g++ -MMD -MF
> obj/oxide/shared/shared/oxide_content_renderer_client.o.d
> -DOXIDE_SUBPROCESS_PATH=\"oxide-qt/oxide-renderer\"
> -DOXIDE_GETTEXT_DOMAIN=\"oxide-qt\" -DOXIDE_SHARED_IMPLEMENTATION
> -DENABLE_MEDIAHUB -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS
> -DENABLE_PDF=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1
> -DUSE_PANGO=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DNO_TCMALLOC
> -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DDISABLE_NACL
> -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DUSE_PROPRIETARY_CODECS
> -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
> -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2
> -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DENABLE_HYBRIS
> -DENABLE_HYBRIS_CAMERA -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL
> -DOXIDE_BUILD -DOXIDE_BUILD -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0
> -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE
> -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS
> -DSK_SUPPORT_GPU=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER
> -DHAVE_PTHREAD -DOXIDE_BUILD -DV8_USE_EXTERNAL_STARTUP_DATA
> -DOPUS_FIXED_POINT -DMESA_EGL_NO_X11_HEADERS -I../.. -Igen
> -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include
> -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12
> -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include
> -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12
> -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include
> -I../../oxide -Igen/oxide -I../../third_party/khronos -I../../gpu
> -I../../third_party/libwebp -I../../third_party/re2/src -Igen/oxide/shared
> -I../../third_party/ced/src -I../../third_party/icu/source/common
> -I../../third_party/icu/source/i18n -I../../skia/config -I../../skia/ext
> -I../../third_party/skia/include/c -I../../third_party/skia/include/config
> -I../../third_party/skia/include/core -I../../third_party/skia/include/effects
> -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy
> -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf
> -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
> -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu
> -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl
> -I../../third_party/protobuf/src -Igen/protoc_out
> -I../../third_party/protobuf/src -I../../third_party/libwebm/source
> -I../../third_party/opus/src/include -I../../third_party/boringssl/src/include
> -I/usr/include/nss -I/usr/include/nspr -Igen -I../../third_party/WebKit
> -Igen/third_party/WebKit -I../../v8/include -Igen/v8/include
> -I../../v8/include -Igen/v8/include -I../../third_part...