Update WebView::OpenURLFromTab for context menu interaction

Bug #1640634 reported by Chris Coulson
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Chris Coulson

Bug Description

The UbuntuWebView context menu "Open <x> in new tab/window" actions will go through this function, but it has a couple of issues:

- It DCHECK's that OpenURLParams::is_renderer_initiated is true.

- It shouldn't call WebContentsClient::ShouldCreateNewWebContents() for context menu initiated calls. We don't want the application to block these (it should create a new tab / window unconditionally)

Changed in oxide:
importance: Undecided → High
status: New → Triaged
milestone: none → branch-1.20
assignee: nobody → Chris Coulson (chrisccoulson)
description: updated
Changed in oxide:
status: Triaged → In Progress
Revision history for this message
Chris Coulson (chrisccoulson) wrote :
Changed in oxide:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers