LocationBarController improvements

Bug #1628496 reported by Chris Coulson
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Chris Coulson

Bug Description

There are several scenarios where we should request that the browser doesn't hide its UI when in auto mode, including:

- SecurityStatus.securityLevel indicates a degraded status.
- The renderer is unresponsive.

We should also review some of the conditions in https://chromium.googlesource.com/chromium/src.git/+/master/chrome/android/java/src/org/chromium/chrome/browser/tab/TopControlsVisibilityDelegate.java#31. This logic should exist in Oxide so that we don't have to expose too many low-level internals (we don't want to expose things like isFocusedNodeEditable, for example).

The behaviour probably doesn't need to be configurable.

For the unresponsive renderer case we'll need some browser-side logic to override the headerbar position, as this is normally driven by the renderer compositor (which we can assume won't be producing any frames in this case).

Changed in oxide:
importance: Undecided → Medium
status: New → Triaged
Changed in oxide:
assignee: nobody → Chris Coulson (chrisccoulson)
milestone: none → branch-1.19
status: Triaged → In Progress
Revision history for this message
Chris Coulson (chrisccoulson) wrote :
Changed in oxide:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers