Cookie store should be created and initialized on the IO thread
Bug #1560271 reported by
Chris Coulson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
High
|
Chris Coulson |
Bug Description
We currently create and initialize the cookie store on the UI thread because it's required to make the UI thread cookie store proxy immediately available to the CookieManager API. However, the cookie store really lives on and is used on the IO thread, and net::CookieStore is not thread safe. Whilst it's sort-of ok for the time being (we guarantee there aren't any concurrent accesses during initialization), this will break if Chromium modifies net::CookieMonster to assert that it's called from a single thread.
Changed in oxide: | |
milestone: | branch-1.15 → branch-1.16 |
Changed in oxide: | |
milestone: | branch-1.16 → branch-1.17 |
Changed in oxide: | |
status: | Triaged → In Progress |
To post a comment you must log in.
In fact, they're already asserting this which means that debug builds will crash on startup