Cookie store should be created and initialized on the IO thread

Bug #1560271 reported by Chris Coulson on 2016-03-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
High
Chris Coulson

Bug Description

We currently create and initialize the cookie store on the UI thread because it's required to make the UI thread cookie store proxy immediately available to the CookieManager API. However, the cookie store really lives on and is used on the IO thread, and net::CookieStore is not thread safe. Whilst it's sort-of ok for the time being (we guarantee there aren't any concurrent accesses during initialization), this will break if Chromium modifies net::CookieMonster to assert that it's called from a single thread.

Chris Coulson (chrisccoulson) wrote :

In fact, they're already asserting this which means that debug builds will crash on startup

Changed in oxide:
importance: Undecided → High
status: New → Triaged
assignee: nobody → Chris Coulson (chrisccoulson)
milestone: none → branch-1.15
Changed in oxide:
milestone: branch-1.15 → branch-1.16
Changed in oxide:
milestone: branch-1.16 → branch-1.17
Changed in oxide:
status: Triaged → In Progress
Chris Coulson (chrisccoulson) wrote :
Changed in oxide:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers