Duplicate targets and random mis-builds due to Chromedriver
Bug #1543587 reported by
Chris Coulson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Oxide |
Fix Released
|
Critical
|
Unassigned | ||
| 1.13 |
Won't Fix
|
Critical
|
Unassigned | ||
| oxide-qt (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Fixed once in bug 1522830, the build is still pulling in //chrome locale targets. This is resulting in duplicate target names (which ninja warns us about), and random misbuilds (whether Oxide or Chrome locale targets are executed is random).
We really really need to stop depending on anything in //chrome. This is a serious layering violation that is going to keep resulting in us pulling in random bits of the Chrome browser.
Related branches
lp:~abreu-alexandre/oxide/remove-chromedriver-build
- Chris Coulson: Approve
-
Diff: 84 lines (+1/-22)5 files modifiedCMakeLists.txt (+0/-8)
build/all.gyp (+1/-9)
build/cmake/OxideCommonOptions.cmake (+0/-1)
build/common.gypi (+0/-1)
build/gyp_oxide (+0/-3)
Revision history for this message
| Chris Coulson (chrisccoulson) wrote | #1 |
Download full text (13.1 KiB)
| Changed in oxide: | |
| importance: | Undecided → Critical |
| status: | New → Triaged |
| Changed in oxide: | |
| milestone: | none → branch-1.14 |
Revision history for this message
| Chris Coulson (chrisccoulson) wrote | #2 |
| Changed in oxide-qt (Ubuntu): | |
| status: | New → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in oxide-qt (Ubuntu): | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #4 |
| Changed in oxide-qt (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in oxide: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
See from the build logs:
ninja: warning: multiple rules generate gen/repack/am.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/ar.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/bg.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/bn.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/ca.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/cs.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/da.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/de.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/el.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/
ninja: warning: multiple rules generate gen/repack/
ninja: warning: multiple rules generate gen/repack/
ninja: warning: multiple rules generate gen/repack/es.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/et.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/fa.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/fi.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/fil.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/fr.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/gu.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/he.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/hi.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/hr.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/hu.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/id.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/it.pak. builds involving this target will not be correct; contin...