Duplicate targets and random mis-builds due to Chromedriver

Bug #1543587 reported by Chris Coulson on 2016-02-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Critical
Unassigned
1.13
Critical
Unassigned
oxide-qt (Ubuntu)
Undecided
Unassigned

Bug Description

Fixed once in bug 1522830, the build is still pulling in //chrome locale targets. This is resulting in duplicate target names (which ninja warns us about), and random misbuilds (whether Oxide or Chrome locale targets are executed is random).

We really really need to stop depending on anything in //chrome. This is a serious layering violation that is going to keep resulting in us pulling in random bits of the Chrome browser.

Chris Coulson (chrisccoulson) wrote :
Download full text (13.1 KiB)

See from the build logs:

ninja: warning: multiple rules generate gen/repack/am.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/ar.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/bg.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/bn.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/ca.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/cs.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/da.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/de.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/el.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/en-GB.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/en-US.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/es-419.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/es.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/et.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/fa.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/fi.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/fil.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/fr.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/gu.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/he.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/hi.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/hr.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/hu.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/id.pak. builds involving this target will not be correct; continuing anyway
ninja: warning: multiple rules generate gen/repack/it.pak. builds involving this target will not be correct; contin...

Changed in oxide:
importance: Undecided → Critical
status: New → Triaged
Changed in oxide:
milestone: none → branch-1.14
Chris Coulson (chrisccoulson) wrote :

This is fixed in the packaging for 1.13

Changed in oxide-qt (Ubuntu):
status: New → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package oxide-qt - 1.13.6-0ubuntu0.15.10.1

---------------
oxide-qt (1.13.6-0ubuntu0.15.10.1) wily-security; urgency=medium

  * Update to v1.13.6 (see USN-2920-1)
    - Bump Chromium rev to 49.0.2623.87
    - Fix LP: #1536797 - Issues with nested event loop handling
    - Fix LP: #1432059 - Stop using Q_DECL_EXPORT
    - Fix LP: #1494900 - Stop building the translation units containing public
      classes as a separate target with different compiler options
    - Fix LP: #1533223 - Use consistent naming of QFlags types (doesn't affect
      the QML API)
    - Fix LP: #1533710 - Various cleanups in soon-to-be-public headers
    - Fix LP: #1463410 - Fold SimplePermissionRequest in to PermissionRequest
      (doesn't affect the QML API)
    - Add a deprecation warning for WebView.loadingChanged
    - Install public headers and CMake package config files
    - Be a bit more intelligent when detecting the availability of the Hybris
      camera compatibility layer and Android EGL platform

  * Add liboxideqtcore-dev and liboxideqtquick-dev packages
    - update debian/control
    - add debian/liboxideqtcore-dev.install
    - add debian/liboxideqtquick-dev.install
  * Refresh gross-hack-for-dual-ffmpeg-build.patch
  * Add build-depends on libffi-dev
    - update debian/control
  * Drop chromedriver build (fixes LP: #1543587)
    - update debian/control
    - update debian/rules
    - remove debian/oxideqt-chromedriver.install

 -- Chris Coulson <email address hidden> Mon, 07 Mar 2016 10:55:29 +0000

Changed in oxide-qt (Ubuntu):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package oxide-qt - 1.13.6-0ubuntu0.14.04.1

---------------
oxide-qt (1.13.6-0ubuntu0.14.04.1) trusty-security; urgency=medium

  * Update to v1.13.6 (see USN-2920-1)
    - Bump Chromium rev to 49.0.2623.877
    - Fix LP: #1536797 - Issues with nested event loop handling
    - Fix LP: #1432059 - Stop using Q_DECL_EXPORT
    - Fix LP: #1494900 - Stop building the translation units containing public
      classes as a separate target with different compiler options
    - Fix LP: #1533223 - Use consistent naming of QFlags types (doesn't affect
      the QML API)
    - Fix LP: #1533710 - Various cleanups in soon-to-be-public headers
    - Fix LP: #1463410 - Fold SimplePermissionRequest in to PermissionRequest
      (doesn't affect the QML API)
    - Add a deprecation warning for WebView.loadingChanged
    - Install public headers and CMake package config files
    - Be a bit more intelligent when detecting the availability of the Hybris
      camera compatibility layer and Android EGL platform

  * Add liboxideqtcore-dev and liboxideqtquick-dev packages
    - update debian/control
    - add debian/liboxideqtcore-dev.install
    - add debian/liboxideqtquick-dev.install
  * Refresh gross-hack-for-dual-ffmpeg-build.patch
  * Add build-depends on libffi-dev
    - update debian/control
  * Drop chromedriver build (fixes LP: #1543587)
    - update debian/control
    - update debian/rules
    - remove debian/oxideqt-chromedriver.install

 -- Chris Coulson <email address hidden> Mon, 07 Mar 2016 10:56:14 +0000

Changed in oxide-qt (Ubuntu):
status: Fix Committed → Fix Released
Changed in oxide:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers