Certificate errors in the browser are confusing
Bug #1504853 reported by
Chris Coulson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
Medium
|
Chris Coulson | ||
webbrowser-app (Ubuntu) |
Confirmed
|
Medium
|
Unassigned |
Bug Description
When the browser displays a certificate error, it indicates the request URL that the error originated from. This is fine. However, if the navigation is content initiated then the addressbar will indicate the URL of the currently committed page (which will be different to the URL of the page causing the error, which is displayed in the error UI provided by the browser).
I have an idea to fix this by navigating the webview to a placeholder interstitial page whilst waiting for a response from the browser. This will update the addressbar, keep the navigation history consistent and also make the back button behave the same as Chrome.
Related branches
lp:~chrisccoulson/oxide/lp1504853
- Chris Coulson: Pending requested
-
Diff: 2354 lines (+1100/-732)22 files modifiedqt/core/api/oxideqcertificateerror.cc (+3/-3)
qt/core/browser/oxide_qt_web_view.cc (+16/-9)
qt/core/browser/oxide_qt_web_view.h (+5/-1)
qt/tests/qmltests/ssl/tst_CertificateError.qml (+329/-217)
qt/tests/qmltests/ssl/tst_CertificateError_initial.html (+5/-0)
shared/browser/oxide_content_browser_client.cc (+21/-21)
shared/browser/oxide_web_frame_tree.cc (+6/-0)
shared/browser/oxide_web_view.cc (+28/-80)
shared/browser/oxide_web_view.h (+0/-26)
shared/browser/oxide_web_view_client.cc (+0/-2)
shared/browser/oxide_web_view_client.h (+0/-2)
shared/browser/oxide_web_view_contents_helper.cc (+7/-1)
shared/browser/ssl/oxide_certificate_error.cc (+50/-268)
shared/browser/ssl/oxide_certificate_error.h (+20/-100)
shared/browser/ssl/oxide_certificate_error_dispatcher.cc (+196/-0)
shared/browser/ssl/oxide_certificate_error_dispatcher.h (+77/-0)
shared/browser/ssl/oxide_certificate_error_dispatcher_client.h (+36/-0)
shared/browser/ssl/oxide_certificate_error_placeholder_page.cc (+58/-0)
shared/browser/ssl/oxide_certificate_error_placeholder_page.h (+64/-0)
shared/browser/ssl/oxide_certificate_error_proxy.cc (+105/-0)
shared/browser/ssl/oxide_certificate_error_proxy.h (+65/-0)
shared/shared.gyp (+9/-2)
Changed in oxide: | |
importance: | Undecided → Medium |
status: | New → In Progress |
assignee: | nobody → Chris Coulson (chrisccoulson) |
milestone: | none → branch-1.11 |
description: | updated |
Changed in oxide: | |
status: | In Progress → Fix Released |
Changed in webbrowser-app (Ubuntu): | |
assignee: | Olivier Tilloy (osomon) → nobody |
To post a comment you must log in.
For non-overridable errors, this change will require webbrowser-app to explicitly destroy CertificateError once the error sheet is dismissed, in order to work correctly.
Olivier, that shouldn't be a problem, should it?