Migrate to using gin bindings

Bug #1496524 reported by Chris Coulson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Triaged
Medium
Chris Coulson

Bug Description

We have some hacky code to expose certain objects on the renderer side to V8 (ScriptMessage, ScriptMessageRequest etc), but we should get rid of this and migrate to using gin bindings instead. See https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/JwSMYicKECQ.

It looks like we just need C++ objects to inherit from gin::Wrappable, and they should implement GetObjectTemplateBuilder(). gin::Handle can be used to retain a gin::Wrappable on the stack, but it doesn't look like gin provides a way to retain one from the heap. We could probably do this easily enough by providing a helper class which takes a gin::Wrappable and holds its wrapper in a v8::Persistent

Changed in oxide:
importance: Undecided → High
importance: High → Medium
status: New → Triaged
assignee: nobody → Chris Coulson (chrisccoulson)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.