Download initiated from context menu’s saveLink/saveMedia doesn’t expose a mime type
Bug #1487090 reported by
Olivier Tilloy
This bug affects 6 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
David Barth | ||
Oxide |
Fix Released
|
Undecided
|
Olivier Tilloy | ||
1.10 |
Fix Released
|
Undecided
|
Olivier Tilloy |
Bug Description
I’m currently hooking the new WebView.contextMenu API (new in oxide 1.8) in webbrowser-app, and on touch devices where the downloadRequested signal is wired to the ContentHub, I’m consistently getting a message saying that there’s no application installed able to handle this type of content (both for hyperlinks of any type, and images).
This appears to be because the download request initiated by saveLink/saveMedia doesn’t expose a mime type, and thus the content hub fails to associate an application to it.
Related branches
lp:~osomon/webbrowser-app/oxide-context-menu
- Ken VanDine: Approve
- Ugo Riboni (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 2579 lines (+1390/-690)34 files modifieddebian/control (+2/-12)
debian/qtdeclarative5-ubuntu-web-plugin-assets.install (+0/-1)
debian/rules (+0/-4)
doc/WebView.qdoc (+44/-5)
src/Ubuntu/Web/CMakeLists.txt (+0/-3)
src/Ubuntu/Web/Selection.qml (+0/-161)
src/Ubuntu/Web/SelectionHandle.qml (+0/-47)
src/Ubuntu/Web/UbuntuWebView02.qml (+60/-156)
src/Ubuntu/Web/selection02.js (+2/-131)
src/app/CMakeLists.txt (+1/-0)
src/app/FileExtensionMapper.js (+11/-7)
src/app/FilePickerDialog.qml (+2/-2)
src/app/WebViewImpl.qml (+20/-9)
src/app/actions/Cut.qml (+23/-0)
src/app/actions/Erase.qml (+23/-0)
src/app/actions/Paste.qml (+23/-0)
src/app/actions/Redo.qml (+23/-0)
src/app/actions/SaveLink.qml (+23/-0)
src/app/actions/SelectAll.qml (+23/-0)
src/app/actions/Undo.qml (+23/-0)
src/app/browserapplication.cpp (+9/-0)
src/app/mime-database.cpp (+33/-0)
src/app/mime-database.h (+39/-0)
src/app/webbrowser/Browser.qml (+103/-26)
src/app/webbrowser/ContextMenuMobile.qml (+168/-0)
src/app/webbrowser/ContextMenuWide.qml (+158/-0)
src/app/webbrowser/assets/stock_link.svg (+164/-0)
src/app/webcontainer/WebViewImplOxide.qml (+42/-5)
tests/autopilot/webbrowser_app/emulators/browser.py (+33/-16)
tests/autopilot/webbrowser_app/tests/http_server.py (+28/-0)
tests/autopilot/webbrowser_app/tests/test_contextmenu.py (+177/-0)
tests/autopilot/webbrowser_app/tests/test_selection.py (+0/-92)
tests/unittests/qml/tst_FileExtensionMapper.qml (+39/-0)
tests/unittests/qml/tst_UbuntuWebView02.qml (+94/-13)
lp:~osomon/oxide/saveImage-mimeType
- Chris Coulson: Pending requested
-
Diff: 193 lines (+55/-9)7 files modifiedqt/tests/qmltests/api/tst_WebView_contextMenu.qml (+7/-4)
shared/browser/oxide_resource_dispatcher_host_delegate.cc (+12/-1)
shared/browser/oxide_web_context_menu.cc (+16/-1)
shared/common/oxide_constants.cc (+4/-1)
shared/common/oxide_constants.h (+5/-2)
shared/renderer/oxide_content_renderer_client.cc (+8/-0)
shared/renderer/oxide_content_renderer_client.h (+3/-0)
tags: | added: regression-proposed |
Changed in oxide: | |
status: | New → Fix Released |
assignee: | nobody → Olivier Tilloy (osomon) |
milestone: | none → branch-1.11 |
Changed in canonical-devices-system-image: | |
status: | Confirmed → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Triaged → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
Changed in canonical-devices-system-image: | |
status: | Fix Released → Triaged |
milestone: | ww40-2015 → ww46-2015 |
Changed in canonical-devices-system-image: | |
status: | Triaged → In Progress |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I just tested with oxide 1.9.0 (from the phablet-team PPA), in the hope that this might be a duplicate of bug #1336611, but it appears it’s not. The issue still exists in 1.9.0.