Change OxideQSecurityStatus::certificate() and OxideQSslCertificate::issuer() to return a QVariant

Bug #1479038 reported by Chris Coulson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Fix Released
High
Chris Coulson
1.9
Fix Released
High
Chris Coulson

Bug Description

Bug 1453294 converted OxideQSslCertificate to a value type. As a consequence, where OxideQSecurityStatus::certificate() and OxideQSslCertificate::issuer() used to return nullptr they now return a value where OxideQSslCertificate::isValid() returns false.

This has a couple of issues:
- It's a slight change in API behaviour. Any applications that are walking the issuer chain and checking for null to detect the top of the chain will now end up in an infinite loop.
- It's weird from QML to have to check SslCertificate.isValid rather than null.

It might be appropriate instead to have these accessors return QVariants. This will allow us to keep OxideQSslCertificate as a value type whilst being able to represent a null certificate.

Changed in oxide:
importance: Undecided → High
status: New → Triaged
milestone: none → branch-1.10
assignee: nobody → Chris Coulson (chrisccoulson)
Changed in oxide:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.