Sort out class construction

Bug #1470190 reported by Chris Coulson on 2015-06-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Undecided
Chris Coulson

Bug Description

As QML doesn't have any concept of construct parameters (any property can be set whilst an object is being constructed) and Oxide needs construct parameters in some cases (eg, WebView.context because we need a BrowserContext to construct WebContents, and WebContext.dataPath because we need a data path before we can construct a BrowserContext), we currently have a fair bit of code that handles this oddity in Oxide.

However, this code is scattered around various places - eg, for WebView, it's in oxide::WebView and OxideQQuickWebView. For WebContext, it's in oxide::qt::WebContext. For UserScript, it's in OxideQQuickUserScriptPrivate. Given that oxide::qt::WebView no longer subclasses oxide::WebView (it's a client of it), it should be easier to refactor this code all in to the same layer.

As this is a limitation of QML, ideally this code would be refactored in to the classes in qt/quick/

Changed in oxide:
milestone: none → branch-1.11
status: New → Fix Released
assignee: nobody → Chris Coulson (chrisccoulson)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers