Additions to LocationBarController API

Bug #1422920 reported by Chris Coulson on 2015-02-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Medium
Chris Coulson

Bug Description

LocationBarController should grow the following extra features:

- show() and hide() methods that would temporarily show or hide the location bar when mode == ModeAuto, without having to change the mode to ModeShown or ModeHidden and then back again to ModeAuto.
- A mechanism to disable the animation when changing mode. A use case for this would be toggling full-screen mode in the browser - in this case it doesn't make sense to hide the location bar with an animation.

Changed in oxide:
milestone: none → branch-1.7
importance: Undecided → Medium
status: New → Triaged
assignee: nobody → Chris Coulson (chrisccoulson)
Olivier Tilloy (osomon) wrote :

Note: the show() and hide() methods are necessary for the browser to properly implement fullscreen mode: when entering fullscreen mode, it’s ok to set mode to ModeHidden, but when exiting it, mode is naturally reset to ModeAuto, which will not change the current position (but does mean it should reveal on scrolling, on touch devices). So when exiting fullscreen there’s no guarantee that the chrome will be shown, it might end up hidden even if it was previously shown (and to make things worse on desktop scrolling won’t reveal the chrome, so it will remain hidden until some other event sets mode to ModeShown).

Changed in oxide:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers