Oxide segfault in reminders app
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
High
|
Olivier Tilloy | ||
1.1 |
Fix Released
|
High
|
Olivier Tilloy |
Bug Description
I started to migrare reminders-app to Oxide[1].
It works well in tablet mode, but in phone mode there is a segfault when I try to open a note (Oxide is used to display notes).
The difference between tablet mode and phone mode is that in tablet mode the note is loaded in a sideview, in phone mode the note is pushed on top of a pagestack.
I'm not able (yet) to reproduce the crash outside the reminders-app, but I don't understand why it crashes so bad. Also, gdb says it's something about loadHtml() function: http://
Please tell me if I could help to give you others informations!
[1]https:/
Related branches
- Chris Coulson: Approve
-
Diff: 81 lines (+37/-4)3 files modifiedqt/tests/qmltests/crash/tst_bug1338639.qml (+20/-0)
shared/browser/oxide_web_view.cc (+16/-4)
shared/browser/oxide_web_view.h (+1/-0)
Changed in oxide: | |
assignee: | nobody → Olivier Tilloy (osomon) |
Changed in oxide: | |
importance: | Undecided → High |
status: | New → Triaged |
Changed in oxide: | |
milestone: | none → branch-1.2 |
Changed in oxide: | |
status: | In Progress → Fix Committed |
Changed in oxide: | |
status: | Fix Committed → Fix Released |
I can reproduce the crash on a nexus 7 with Riccardo’s branch. The crash happens on this line:
web_ contents_ ->GetController ().LoadURLWithP arams(params) ;
because web_contents_ is null.
This means that LoadData() is being called before the webview has been initialized. We should guard against that in oxide, and I’m going to look into why loadHtml() is being called too early on the webview.