Hyperlinks that request a new tab don’t open
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
Critical
|
Olivier Tilloy | ||
webbrowser-app |
Fix Released
|
Critical
|
Olivier Tilloy | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
In the webbrowser-app, when clicking on a link that is supposed to open a new window (e.g. href w/ target="_blank" or window.open()), nothing actually happens.
The fix for the bug is in 2 parts:
- enabling proper popup handling in the webbrowser-app (and handle catching the creation
signals from oxide and creating the proper extra tab),
- fixing an issue in Oxide that prevented *in some instances* the signal that requested the new webview corresponding to the navigation to be created NOT to be sent,
[Test Case]
- Open twitter.com in the webbrowser-app
- Try to click on a link in a tweet
- Result: it should create a new tab in the webbrowser-app with the content corresponding to the clicked link,
[Regression Potential]
The fixes are mostly centered around the tab creation and navigation feature in the webbrowser-app. So areas around those would be impacted (in the handling and creation of those in reaction to the user clicking)
Related branches
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Alexandre Abreu (community): Approve
-
Diff: 207 lines (+19/-49)5 files modifiedsrc/Ubuntu/Components/Extras/Browser/UbuntuWebView02.qml (+1/-29)
src/app/webbrowser/Browser.qml (+15/-8)
src/app/webbrowser/webbrowser-app.qml (+1/-1)
src/app/webcontainer/WebViewImplOxide.qml (+2/-6)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+0/-5)
Changed in webbrowser-app: | |
importance: | Undecided → Critical |
assignee: | nobody → Olivier Tilloy (osomon) |
Changed in webbrowser-app: | |
status: | Confirmed → In Progress |
Changed in oxide: | |
status: | New → In Progress |
assignee: | nobody → Olivier Tilloy (osomon) |
importance: | Undecided → Critical |
tags: | added: oxide webapps-blocker |
description: | updated |
Changed in oxide: | |
status: | Fix Committed → Fix Released |
Changed in webbrowser-app: | |
status: | In Progress → Fix Released |
(after enabling JS logging) I’m not seeing any relevant errors when clicking a link.