Refine WebView.navigationRequested and WebView.newViewRequested
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
Medium
|
Unassigned |
Bug Description
I initially thought that all top-level navigations would result in WebView.
However, there are some exceptions which make the current API a bit confusing:
- window.open() only results in WebView.
- Clicking on an anchor with target="_blank" only results in WebView.
- Clicking with modifiers on an anchor that has no target results in both WebView.
- Subframe navigations that have a disposition of CurrentTab don't result in any signal, but this one is expected.
- Browser-initiated navigations don't result in either signal, but this is deliberate too.
I think this should probably be cleaned up by:
- Removing NavigationReque
- Dispatch only WebView.
Changed in oxide: | |
importance: | Undecided → High |
status: | New → Confirmed |
status: | Confirmed → Triaged |
Actually, thinking about this a bit more, this is probably ok - it would allow extending NavigationRequest later on to turn a same-window navigation in to a new-window navigation (and vice-versa) by adding some more values to the Action enum