Oxide

Deliver console messages to embedder

Bug #1291389 reported by Chris Coulson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Fix Released
Low
Alexandre Abreu

Bug Description

Currently, we don't implement WebContentsDelegate::AddMessageToConsole(), which means all console messages from JS in the renderer get logged to the current terminal. We should implement this and route these to a signal on the WebView

Related branches

lp:~abreu-alexandre/oxide/deliver-console-message-to-embedder
Chris Coulson: Approve
Diff: 205 lines (+90/-0)
8 files modified
qt/core/browser/oxide_qt_web_view.cc (+13/-0)
qt/core/browser/oxide_qt_web_view.h (+5/-0)
qt/core/glue/oxide_qt_web_view_adapter.h (+6/-0)
qt/quick/api/oxideqquickwebview.cc (+19/-0)
qt/quick/api/oxideqquickwebview_p.h (+16/-0)
qt/quick/api/oxideqquickwebview_p_p.h (+5/-0)
shared/browser/oxide_web_view.cc (+15/-0)
shared/browser/oxide_web_view.h (+11/-0)
lp:~oxide-developers/oxide/packaging.trusty
Chris Coulson (chrisccoulson)
Changed in oxide:
importance: Undecided → Low
status: New → Triaged
Alexandre Abreu (abreu-alexandre)
Changed in oxide:
status: Triaged → In Progress
assignee: nobody → Alexandre Abreu (abreu-alexandre)
Chris Coulson (chrisccoulson)
Changed in oxide:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.