Add an API to expose webpage thumbnails
Bug #1260009 reported by
Olivier Tilloy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Invalid
|
Medium
|
Olivier Tilloy |
Bug Description
The current ubuntu touch webbrowser app displays square thumbnails of the web pages for open tabs as well as bookmarks and history entries. It’s currently implemented as a crude hack and requires linking against QtWebKit’s private headers.
We will need oxide to expose those thumbnails in an easy way for the application to manage them.
Related branches
lp:~osomon/oxide/thumbnails
On hold
for merging
into
lp:~oxide-developers/oxide/oxide.trunk
- Chris Coulson: Pending requested
-
Diff: 576 lines (+306/-8)17 files modifiedqt/core/browser/oxide_qt_web_view.cc (+27/-7)
qt/core/browser/oxide_qt_web_view.h (+3/-0)
qt/core/glue/oxide_qt_web_view_adapter.cc (+4/-0)
qt/core/glue/oxide_qt_web_view_adapter.h (+5/-0)
qt/quick/CMakeLists.txt (+1/-0)
qt/quick/api/oxideqquickwebthumbnail.cc (+54/-0)
qt/quick/api/oxideqquickwebthumbnail_p.h (+59/-0)
qt/quick/api/oxideqquickwebthumbnail_p_p.h (+41/-0)
qt/quick/api/oxideqquickwebview.cc (+14/-0)
qt/quick/api/oxideqquickwebview_p.h (+4/-0)
qt/quick/api/oxideqquickwebview_p_p.h (+2/-0)
qt/quick/oxide_qml_plugin.cc (+3/-0)
qt/tests/qmltests/api/tst_WebView_thumbnail.qml (+44/-0)
shared/browser/oxide_render_widget_host_view.cc (+1/-0)
shared/browser/oxide_render_widget_host_view.h (+2/-0)
shared/browser/oxide_web_view.cc (+36/-1)
shared/browser/oxide_web_view.h (+6/-0)
Changed in oxide: | |
importance: | Undecided → Medium |
assignee: | nobody → Chris Coulson (chrisccoulson) |
Changed in oxide: | |
assignee: | Chris Coulson (chrisccoulson) → Olivier Tilloy (osomon) |
Changed in oxide: | |
status: | New → In Progress |
tags: | added: rtm14 |
Changed in oxide: | |
milestone: | none → branch-1.2 |
Changed in oxide: | |
milestone: | branch-1.2 → branch-1.3 |
Changed in oxide: | |
milestone: | branch-1.3 → branch-1.4 |
Changed in oxide: | |
milestone: | branch-1.4 → branch-1.5 |
Changed in oxide: | |
milestone: | branch-1.5 → branch-1.6 |
To post a comment you must log in.
I had a quick look at how thumbnailing works in Chrome, it uses RenderWidgetHos t::CopyFromBack ingStore( …) (see https:/ /code.google. com/p/chromium/ codesearch# chromium/ src/content/ public/ browser/ render_ widget_ host.h& cl=GROK& ct=xref_ jump_to_ def&l=199& gsn=CopyFromBac kingStore).