Expose an 'icon' property on OxideQQuickWebView
Bug #1259216 reported by
Olivier Tilloy
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
High
|
Olivier Tilloy | ||
webbrowser-app |
Fix Released
|
Medium
|
Olivier Tilloy | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Undecided
|
Olivier Tilloy |
Bug Description
For feature parity with QtWebKit, we need to expose an 'icon' property on the QML WebView, to access the favicon of the current page, if any.
Related branches
lp:~osomon/oxide/icon
- Chris Coulson: Approve
-
Diff: 220 lines (+82/-1)10 files modifiedqt/core/browser/oxide_qt_web_view.cc (+4/-0)
qt/core/browser/oxide_qt_web_view.h (+1/-0)
qt/core/glue/oxide_qt_web_view_adapter.h (+1/-0)
qt/quick/api/oxideqquickwebview.cc (+15/-0)
qt/quick/api/oxideqquickwebview_p.h (+4/-0)
qt/quick/api/oxideqquickwebview_p_p.h (+3/-1)
qt/tests/qmltests/api/tst_WebView_icon.html (+5/-0)
qt/tests/qmltests/api/tst_WebView_icon.qml (+32/-0)
shared/browser/oxide_web_view.cc (+13/-0)
shared/browser/oxide_web_view.h (+4/-0)
lp:~osomon/webbrowser-app/icon
- PS Jenkins bot: Approve (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 119 lines (+13/-5)8 files modifieddebian/control (+1/-1)
src/app/webbrowser/BookmarksView.qml (+1/-0)
src/app/webbrowser/Browser.qml (+2/-2)
src/app/webbrowser/NewTabView.qml (+1/-0)
src/app/webbrowser/PageDelegate.qml (+2/-1)
src/app/webbrowser/TabsList.qml (+1/-0)
src/app/webbrowser/TimelineView.qml (+1/-0)
src/app/webbrowser/UrlDelegate.qml (+4/-1)
Changed in oxide: | |
assignee: | nobody → Olivier Tilloy (osomon) |
importance: | Undecided → High |
tags: | added: desktop webapp-container |
Changed in oxide: | |
status: | New → In Progress |
tags: | added: webapps-blocker |
tags: |
added: webapps-hotlist removed: webapps-blocker |
Changed in oxide: | |
status: | In Progress → Fix Committed |
Changed in webbrowser-app: | |
importance: | Undecided → Medium |
assignee: | nobody → Olivier Tilloy (osomon) |
Changed in oxide: | |
milestone: | none → branch-1.1 |
status: | Fix Committed → Fix Released |
Changed in webbrowser-app: | |
status: | New → In Progress |
Changed in webbrowser-app (Ubuntu): | |
assignee: | nobody → Olivier Tilloy (osomon) |
status: | New → In Progress |
Changed in webbrowser-app: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package webbrowser-app - 0.23+14. 10.20140709- 0ubuntu1
--------------- 10.20140709- 0ubuntu1) utopic; urgency=low
webbrowser-app (0.23+14.
[ Michael Sheldon ]
* Add support for downloads via content-hub on non-desktop devices
when it's either not possible to render a file within the browser
itself or when a download is explicitly requested via the Content-
Disposition header. (LP: #1198347)
[ Olivier Tilloy ]
* Remove a workaround for bug #1322622 that has been properly fixed in
oxide. (LP: #1322622)
* Re-enable the favicon support now that oxide supports it. (LP:
#1259216)
-- Ubuntu daily release <email address hidden> Wed, 09 Jul 2014 16:37:04 +0000