Add an API to allow content scripts to bind objects to the main world global object
Bug #1221996 reported by
Chris Coulson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Oxide |
Fix Released
|
High
|
Alexandre Abreu | ||
| 1.3 |
Fix Released
|
High
|
Alexandre Abreu | ||
Bug Description
As all content scripts run in an isolated world, properties they modify on their global object are not reflected in to the main world. This makes it difficult for content scripts to add new API's.
It looks like unity-chromium-
In oxide, it would be nice to have an API that allows content scripts to bind an object to the main world global object, rather than having to insert script elements in to a page.
Related branches
lp:~abreu-alexandre/oxide/content-script-injection-main-world
- Chris Coulson: Needs Fixing
- Maxim Ermilov (community): Needs Fixing
-
Diff: 522 lines (+288/-19)12 files modifiedqt/tests/qmltests/core/tst_WebView_scriptMainWorld.html (+12/-0)
qt/tests/qmltests/core/tst_WebView_scriptMainWorld.qml (+112/-0)
qt/tests/qmltests/core/tst_WebView_scriptMainWorld_user_script.js (+10/-0)
shared/common/oxide_constants.cc (+5/-0)
shared/common/oxide_constants.h (+5/-0)
shared/renderer/oxide_isolated_world_map.cc (+8/-0)
shared/renderer/oxide_script_message_dispatcher_renderer.cc (+17/-8)
shared/renderer/oxide_script_message_dispatcher_renderer.h (+2/-0)
shared/renderer/oxide_script_message_manager.cc (+24/-11)
shared/renderer/oxide_script_message_manager.h (+4/-0)
shared/renderer/oxide_user_script_slave.cc (+84/-0)
shared/renderer/oxide_user_script_slave.h (+5/-0)
| Changed in oxide: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| Changed in oxide: | |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
| tags: | added: desktop webapp-container |
| tags: | added: webapps-blocker |
| Changed in oxide: | |
| status: | Triaged → In Progress |
| tags: |
added: html5-blocker removed: desktop webapp-container webapps-blocker |
| tags: | added: rtm14 |
| tags: | added: touch-2014-09-18 |
| Changed in oxide: | |
| importance: | Medium → Critical |
| tags: |
added: touch-2014-10-09 removed: touch-2014-09-18 |
Revision history for this message
| David Barth (dbarth) wrote | #1 |
| tags: |
added: ota-1 removed: rtm14 |
| Changed in oxide: | |
| importance: | Critical → High |
Revision history for this message
| Jamie Strandboge (jdstrand) wrote | #2 |
| tags: |
added: touch-2014-10-16 removed: touch-2014-10-09 |
| Changed in oxide: | |
| status: | In Progress → Fix Released |
| milestone: | none → 1.3.0 |
| Changed in oxide: | |
| milestone: | 1.3.0 → branch-1.3 |
To post a comment you must log in.
Adjusting the priorities. It is required to remove qtwebkit, but is not a user facing issue.