Integer overflow when reading large files

Bug #1220388 reported by Chris Coulson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Triaged
Low
Unassigned

Bug Description

base::File::Info::size is an int64, but base::FileProxy::Read() takes an int for the size. In oxide::GetFileContentsJob::OnGotFileInfo, we call Read() with the size returned from base::FileProxy::GetInfo(), causing a possible integer overflow for files larger than 2GB (the result of which would be that we wouldn't read the entire file).

This code is currently only used for reading user scripts, and it's unlikely we're going to be loading any this size anyway

description: updated
summary: - Possible integer overflow when reading files
+ Integer overflow when reading large files
information type: Private Security → Public
Changed in oxide:
importance: Undecided → Low
status: New → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.