Use of old thread module in a unit test

Bug #1875678 reported by Joel Capitao
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ovsdbapp
Fix Released
Medium
Terry Wilson

Bug Description

At RDO we are hitting an issue while building the package [1] for Ussuri.
The issue happens while running the unit tests in %check step.
Below the error:
AttributeError: module 'ovsdbapp.api' has no attribute 'thread'

We have eventlet in our buildroot, so we run [2]. In tox, as eventlet is absent, we don't hit the issue.

We think the unit test has not been updated during this commit [3].

We will disable unit test execution on our side until this is fixed.

[1] https://logserver.rdoproject.org/33/26333/1/check/DLRN-rpmbuild-centos8/6e3e5b3/job-output.txt
[2] https://github.com/openstack/ovsdbapp/blob/aadf1624ef9f8c8b92601ccb973775f508f7f11c/ovsdbapp/tests/unit/test_api.py#L46
[3] https://github.com/openstack/ovsdbapp/commit/7ced5efa150dab2edf96dbe9c5d57956f030d96e

Changed in ovsdbapp:
assignee: nobody → Terry Wilson (otherwiseguy)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovsdbapp (master)

Reviewed: https://review.opendev.org/743001
Committed: https://git.openstack.org/cgit/openstack/ovsdbapp/commit/?id=48ee1008f59eed95cbca7a8b1b3630ddbffdaae5
Submitter: Zuul
Branch: master

commit 48ee1008f59eed95cbca7a8b1b3630ddbffdaae5
Author: Terry Wilson <email address hidden>
Date: Fri Jul 24 16:42:17 2020 -0500

    Fix thread/threading change in unit test

    This unit test was not updated when the thread/threading name
    change happened. This fixes the unit test when eventlet is
    installed.

    Change-Id: I0e0da83187190c7145bb01f77daf22a43868115c
    Closes-bug: #1875678

Changed in ovsdbapp:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.