LrNatDelCommand fails when match_ip is IP prefix

Bug #1825740 reported by Abhiram Sangana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ovsdbapp
Fix Released
Undecided
Abhiram Sangana

Bug Description

__init__ of LrNatDelCommand in schema/ovn_northbound/commands.py takes optional match_ip parameter to find one or more specific NAT Table rows of a logical router to delete. This match_ip is searched in the "logical_ip" column for NAT rows of type "snat". "logical_ip" column value can be IPv4 network or IP address. Currently the code only allows IP address and raises an error when an IP network is passed.

Changed in ovsdbapp:
assignee: nobody → Abhiram Sangana (abh1ram)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovsdbapp (master)

Fix proposed to branch: master
Review: https://review.opendev.org/654261

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovsdbapp (master)

Reviewed: https://review.opendev.org/654261
Committed: https://git.openstack.org/cgit/openstack/ovsdbapp/commit/?id=9f8dc4494dd5b273a282d21cc15057086624029d
Submitter: Zuul
Branch: master

commit 9f8dc4494dd5b273a282d21cc15057086624029d
Author: Abhiram Sangana <email address hidden>
Date: Sun Apr 21 11:36:32 2019 -0700

    Allow match_ip in LrNatDelCommand to be IP network

    __init__ of LrNatDelCommand in schema/ovn_northbound/commands.py takes
    optional match_ip parameter to find one or more specific NAT Table rows
    of a logical router to delete. This match_ip is searched in the
    "logical_ip" column for NAT rows of type "snat" and in "external_ip"
    column for other types. While "external_ip" column value has to be an
    IP address, "logical_ip" column value can be IPv4 network or
    IP address. Currently the code only allows match_ip to be an IP address
    and raises an error when an IP network is passed.

    This change allows match_ip to be IP network when NAT type is "snat".

    Closes-Bug: #1825740
    Change-Id: I90dfdb5b5fe625ca8af768dfe9dac10f6d3c1430

Changed in ovsdbapp:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovsdbapp 0.16.0

This issue was fixed in the openstack/ovsdbapp 0.16.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.