dns_remove_record() fails with KeyError exception

[Lucas Alvares Gomes]

Original report: https://bugzilla.redhat.com/show_bug.cgi?id=1629934

The method dns_remove_record() from ovsdbapp does not support the parameter "if_exist" therefore, if the record being removed do not exist in OVNDB it will raise an KeyError exception which causing other methods in networking ovn such as add_txns_to_sync_port_dns_records() and add_txns_to_remove_port_dns_record() to also fail.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603333
Committed: https://git.openstack.org/cgit/openstack/ovsdbapp/commit/?id=31a476435373a8c6581ad66d96fbe314711e7f36
Submitter: Zuul
Branch: master

commit 31a476435373a8c6581ad66d96fbe314711e7f36
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Sep 18 10:07:05 2018 +0100

    NBDB API: Add param if_exists for methods using db_remove()

    This patch is adding the parameter "if_exists" to the methods in the
    Northbound DB API that uses the db_remove() method underneath.

    The following methods were affected:

    * dns_remove_record()
    * ls_remove_dns_record()

    The intention of this patch is to make the API more flexible for
    projects relying on those methods so they can choose whether they want
    to raise an exception if the item being removed exist or not.

    Closes-Bug: #1793132
    Change-Id: I1e6749a9f3827f91a9db29e6f5ba0c8b7a6cc622

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovsdbapp 0.13.0 release.