functional tests are filled with POLLIN messages from ovs even when it's not using ovs itself

Bug #1687065 reported by Ihar Hrachyshka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Terry Wilson
ovsdbapp
Confirmed
Undecided
Unassigned

Bug Description

Example: http://logs.openstack.org/27/451527/5/check/gate-neutron-dsvm-functional-ubuntu-xenial/da67f5f/logs/dsvm-functional-logs/neutron.tests.functional.agent.linux.test_linuxbridge_arp_protect.LinuxBridgeARPSpoofTestCase.test_arp_protection_update.txt.gz

This test has nothing to do with ovs, but still, it's trashed with POLLIN messages. Probably because some previous test case in the worker initialized ovslib and got a logging thread spinned up.

Ideally, we would not have the thread running in non-ovs scope, meaning we would need some way to kill/disable it when not needed. Maybe a fixture in ovsdbapp for that matter (or ovs lib itself) that would restore the state to pre-init could help. Then we could use the fixture in our base test classes.

Changed in ovsdbapp:
status: New → Confirmed
Changed in neutron:
status: New → Confirmed
importance: Undecided → Low
tags: added: functional-tests usability
tags: added: logging
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562385

Changed in neutron:
assignee: nobody → Terry Wilson (otherwiseguy)
status: Confirmed → In Progress
Revision history for this message
Terry Wilson (otherwiseguy) wrote :

I posted a patch to just disable the ovsdb debug logging by default. There is ovsdbapp.backend.ovs_idl.fixtures.OvsdbVlogFixture which could be used in functional test setup. It wouldn't kill the thread, but would un-patch the logging. ovsdbapp now allows one to shut down the connection to OVS when you are done with it, so it would also be possible to set up an OvsdbConnection fixture that stops at the end of the test as well.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/562385
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7326717d36d31e2cc383b535a4af06f0dae9e56d
Submitter: Zuul
Branch: master

commit 7326717d36d31e2cc383b535a4af06f0dae9e56d
Author: Terry Wilson <email address hidden>
Date: Wed Apr 18 15:57:18 2018 -0500

    Make OVSDB debug logging optional

    OVSDB debug messages are very chatty and make log files much bigger
    without a lot of benefit 99.9% of the time. If there is ever a need
    for them because we are having a *really* weird OVSDB issue, then
    we can configure the jobs to turn them back on.

    Change-Id: I1d1e5e312509022084bcb651968bb9543ff61ba4
    Closes-Bug: #1687065

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 13.0.0.0b2

This issue was fixed in the openstack/neutron 13.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.