Comment 6 for bug 290190

Revision history for this message
Arjen Lentz (arjen-lentz) wrote :

(Pasting your note from email)
> in revision 38 there's a slight alteration for Solaris (ironically enough not the sed line).
> Basically, instead of $() it's using backticks which is compatible with Solaris' /bin/sh

> But the patch you pasted works for any Linux distro and FreeBSD version
> conceived on this side of the moon landing.

Ok, great work - but... ;-)
I think we need to patch this in a different spot: extra/my_print_defaults.c
Then any other scripts/tools that use the same will also be fixed, rather than just mysqld_safe.
Also, some distros replace/patch mysqld_safe (have their own foo) but the my_print_defaults binary should always be around and get updated.

I would suggest we fix this in main() in or just before the loop that outputs the params:
  for (argument= arguments+1 ; *argument ; argument++)
    puts(*argument);