[devstack plugin]cells1 conductor config file isn't modified by the plugin

Bug #1731856 reported by Matt Simonin
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
osprofiler
Fix Released
Undecided
Ilya Shakhat

Bug Description

It seems that devstack now deploys a cell0 and a cell1, each running one conductor.
The osprofiler plugin runs in the post-config phase to add the profiler section and the corresponding values in the NOVA_CONF file. The conductor of cell0 is well configured but the conductor of the cell1 miss the profiler section in its configuration.

My (partial) understanding so far is that the configuration of the cells1's conductor is build from scratch[1] and not derived from a the base nova.conf[2]. The osprofiler devstack plugin only modify the base nova.conf file.

[1]: https://github.com/openstack-dev/devstack/blob/2e3c96a3ad1672eeddbc4a9a7d3eeda6a68e88be/lib/nova#L586-L601

Revision history for this message
Ilya Shakhat (shakhat) wrote :

Cell conductor is executed with its own config file (/usr/bin/python /usr/bin/nova-conductor --config-file /etc/nova/nova_cell1.conf), but currently this file is not in a list in osprofiler's Devstack plugin (https://github.com/openstack/osprofiler/blob/master/devstack/lib/osprofiler#L14-L29)

Changed in osprofiler:
status: New → Confirmed
Ilya Shakhat (shakhat)
Changed in osprofiler:
assignee: nobody → Ilya Shakhat (shakhat)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to osprofiler (master)

Fix proposed to branch: master
Review: https://review.openstack.org/533139

Changed in osprofiler:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to osprofiler (master)

Reviewed: https://review.openstack.org/533139
Committed: https://git.openstack.org/cgit/openstack/osprofiler/commit/?id=afa98f3880ccbb3fc098120e2ecfe8a59a83b5e7
Submitter: Zuul
Branch: master

commit afa98f3880ccbb3fc098120e2ecfe8a59a83b5e7
Author: Ilya Shakhat <email address hidden>
Date: Fri Jan 12 10:36:01 2018 +0100

    Initialize osprofiler in Nova Cell configs

    Nova Cell conductor has its own config file and Devstack plugin
    should update it when osprofiler is enabled.

    Change-Id: Iaa6a8de9ab9d8a27ff9bf9d56ee62cd8d290609a
    Closes-Bug: #1731856

Changed in osprofiler:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/osprofiler 2.0.0

This issue was fixed in the openstack/osprofiler 2.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.