cleanup-orphaned-vms.sh not recognise boot from volume instances

Bug #1816434 reported by Davide on 2019-02-18
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
OpenStack Operators
Undecided
Davide

Bug Description

Previous method verify if line that contain "source file" exists into dumpxml of every virtual machine to extract uuid of virtual machines running on hypervisor but this line exists only when a disk file is present on the host and boot from volumes for example has not "source file" line into dumpxml and this script will kill them. To avoid theese case it should be possible to use virsh list --uuid --all to list directly the virtual machine uuids of nova instances. This changes avoid to shut running customer virtual machines.

Davide (dpanarese) on 2019-02-18
Changed in osops:
assignee: nobody → Davide (dpanarese)
status: New → Confirmed
Davide (dpanarese) on 2019-02-18
Changed in osops:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to osops-tools-generic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/637555

Davide (dpanarese) on 2019-02-18
Changed in osops:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on osops-tools-generic (master)

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/637555
Reason: https://review.openstack.org/#/c/633187/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to osops-tools-generic (master)

Reviewed: https://review.openstack.org/633187
Committed: https://git.openstack.org/cgit/openstack/osops-tools-generic/commit/?id=e2275cbf6d67fc846cbcff191c368f719dfe6d9c
Submitter: Zuul
Branch: master

commit e2275cbf6d67fc846cbcff191c368f719dfe6d9c
Author: Davide Panarese <email address hidden>
Date: Fri Jan 25 12:23:30 2019 +0100

    Review uuid verification method

    Previous method verify if line that contain "source file"
    exists into dumpxml of every virtual machine to extract
    uuid of virtual machines running on hypervisor but this
    line exists only when a disk file is present on the host
    and boot from volumes for example has not "source file" line
    into dumpxml and this script will kill them.
    To avoid theese case it should be possible to use
    'virsh list --uuid --all' to list directly the virtual machine
    uuids of nova instances.
    This changes avoid to shut running customer virtual machines.

    This also fixes handling of --noop by correcting the condition checking
    for arguments.

    Change-Id: Ib9ec04a37bfe69e323f14f6bf4cb72b0fa818803
    Closes-Bug: #1816434
    Signed-off-by: Davide Panarese <email address hidden>

Changed in osops:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers