Some files in osops-tools-generic still not passing bashate job

Bug #1534660 reported by Mike Dorman
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Operators
Undecided
Peter Jenkins

Bug Description

Although I thought we had all this fixed, there are still some files in the osops-tools-generic repo that are not passing the bashate tests. I.e. see the failures (which are unrelated to the change) on https://review.openstack.org/#/c/266873/2

Revision history for this message
Peter Jenkins (peterjenkins) wrote :

I can fix this sillyness.

Changed in osops:
assignee: nobody → Peter Jenkins (peterjenkins)
Revision history for this message
Peter Jenkins (peterjenkins) wrote :
Mike Dorman (mdorman-m)
Changed in osops:
status: New → Fix Committed
Revision history for this message
Simon Leinen (simon-leinen) wrote :

Unfortunately this change caused a regression in nova/openstack_db_archive.sh. I'll create a new bug and will propose a fix.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to osops-tools-generic (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/334176

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to osops-tools-generic (master)

Reviewed: https://review.openstack.org/334176
Committed: https://git.openstack.org/cgit/openstack/osops-tools-generic/commit/?id=df055acc61c82c1ddc9e55da7f840be15a993ff2
Submitter: Jenkins
Branch: master

commit df055acc61c82c1ddc9e55da7f840be15a993ff2
Author: Simon Leinen <email address hidden>
Date: Sat Jun 25 16:31:05 2016 +0200

    Avoid passing backslashes in SQL snippets

    In order to fix bug #1534660, change 269530 splits many overly long
    lines in Bash scripts using backslash continuations. But in some
    cases, these backslashes were inserted within command arguments that
    are interpreted as SQL expressions, where they cause syntax errors.

    This changes splits the corresponding lines differently, so that the
    backslashes are no longer passed in SQL expressions.

    Change-Id: I4a8940b6fe9ce8563315cd0cc9a9529a02f8cdb8
    Closes-Bug: 1596193
    Related-Bug: 1534660

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers