Avoid hidden/automatic six.add_moves of mock replacements
Bug #1416143 reported by
Joshua Harlow
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| oslotest |
Fix Released
|
Low
|
Lei Zhang | ||
Bug Description
It would be great if importing oslotest doesn't magically add moved locations to six;
This creates import ordering issues where a six.moves.mock may or may not exist depending on the import ordering of oslotest.
It would be really great to avoid these kinds of hidden side-effects of importing the test code.
| Changed in oslotest: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| Changed in oslotest: | |
| assignee: | nobody → Lei Zhang (lei-a-zhang) |
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
Revision history for this message
| Davanum Srinivas (DIMS) (dims-v) wrote | #2 |
| Changed in oslotest: | |
| status: | Confirmed → Fix Committed |
| Changed in oslotest: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Wait, I don't understand.
The import in oslotest is deterministic.
The problem though is that the change wasn't done upstream in six, but in oslotest. To fix:
1) submit a patch to six.
2) remove from oslotest.