pbr incompatible with sphinx 1.3b1
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| PBR |
Medium
|
Ian Y. Choi | ||
| oslotest |
High
|
Unassigned |
Bug Description
sphinx 1.3b1 was released on oct 9th, seems to be causing issues
Seen here: http://
2014-10-10 22:20:03.512 | running build_sphinx
2014-10-10 22:20:03.512 | creating /home/jenkins/
2014-10-10 22:20:03.513 | creating /home/jenkins/
2014-10-10 22:20:03.513 | Traceback (most recent call last):
2014-10-10 22:20:03.514 | File "setup.py", line 30, in <module>
2014-10-10 22:20:03.514 | pbr=True)
2014-10-10 22:20:03.514 | File "/usr/lib/
2014-10-10 22:20:03.516 | dist.run_commands()
2014-10-10 22:20:03.516 | File "/usr/lib/
2014-10-10 22:20:03.525 | self.run_
2014-10-10 22:20:03.525 | File "/usr/lib/
2014-10-10 22:20:03.525 | cmd_obj.run()
2014-10-10 22:20:03.526 | File "/home/
2014-10-10 22:20:03.526 | self._sphinx_run()
2014-10-10 22:20:03.526 | File "/home/
2014-10-10 22:20:03.526 | sphinx_
2014-10-10 22:20:03.527 | TypeError: init_values() takes exactly 2 arguments (1 given)
2014-10-10 22:20:03.549 | ERROR: InvocationError: '/home/
Doug Hellmann (doug-hellmann) wrote : | #1 |
Changed in oslotest: | |
status: | New → In Progress |
assignee: | nobody → Doug Hellmann (doug-hellmann) |
milestone: | none → next-kilo |
importance: | Undecided → High |
Jeremy Stanley (fungi) wrote : | #2 |
Was this actually impacting other projects, or just oslotest?
Jeremy Stanley (fungi) wrote : | #3 |
According to logstash data this error was only ever encountered twice in the past week, both times on oslotest change 120316, roughly 19 hours apart. http://
Jeremy Stanley (fungi) wrote : | #4 |
With a current version of tox, running 'tox -e pep8' in an up to date checkout of openstacl/
Changed in oslotest: | |
assignee: | Doug Hellmann (doug-hellmann) → Jeremy Stanley (fungi) |
Changed in oslotest: | |
assignee: | Jeremy Stanley (fungi) → nobody |
Jeremy Stanley (fungi) wrote : | #5 |
I missed that my https:/
I've proposed an optional revert of the unnecessary openstack/
Changed in oslotest: | |
status: | In Progress → Fix Committed |
Changed in oslotest: | |
status: | Fix Committed → Fix Released |
summary: |
- sphinx 1.3b1 breaks the world + pbr incompatible with sphinx 1.3b1 |
Changed in pbr: | |
importance: | Undecided → Medium |
status: | New → Triaged |
Fix proposed to branch: master
Review: https:/
Changed in pbr: | |
assignee: | nobody → Thomas Bechtold (toabctl) |
status: | Triaged → In Progress |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 1dfe9ef348c777b
Author: Thomas Bechtold <email address hidden>
Date: Tue Jun 2 18:40:38 2015 +0200
Remove sphinx_
The function signature for Sphinx's config.
version 1.3. That leads to:
TypeError: init_values() takes exactly 2 arguments (1 given)
But the function is already correctly called from
application
from the application instead of creating an own config object.
Change-Id: I343c26560bfe51
Closes-Bug: #1379998
Changed in pbr: | |
status: | In Progress → Fix Committed |
Changed in pbr: | |
status: | Fix Committed → In Progress |
Changed in pbr: | |
status: | In Progress → Fix Committed |
Thomas Bechtold (toabctl) wrote : | #8 |
This commit was reverted and is still in review. See https:/
Antoine "hashar" Musso (hashar) wrote : | #9 |
Changed pbr status to confirmed.
Changed in pbr: | |
status: | Fix Committed → Confirmed |
Matthew Pounsett (g-matt-l) wrote : | #10 |
This is also blocking compilation of the virtualenvwrapper package on, at least, FreeBSD:
22:06:15 (504) % sudo make
===> Building for py27-virtualenv
running build_sphinx
[pbr] Generating AUTHORS
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "setup.py", line 7, in <module>
pbr=True,
File "/usr/local/
dist.
File "/usr/local/
self.
File "/usr/local/
cmd_obj.run()
File "/usr/local/
self.
File "/usr/local/
sphinx_
TypeError: init_values() takes exactly 2 arguments (1 given)
*** [do-build] Error code 1
Stop in /usr/ports/
*** [stage] Error code 1
Stop in /usr/ports/
Change abandoned by Thomas Bechtold (<email address hidden>) on branch: master
Review: https:/
Reason: Fixed by http://
But without tests and warnings disabled. Anyway - at least newer Sphinx versions are working now.
Fix proposed to branch: master
Review: https:/
Changed in pbr: | |
assignee: | Thomas Bechtold (toabctl) → Ian Y. Choi (ianychoi) |
status: | Confirmed → In Progress |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit a5d46d5ce7b6909
Author: Ian Y. Choi <email address hidden>
Date: Mon Nov 9 21:14:47 2015 +0900
More support Sphinx >=1.3b1 and <1.3.1
Although https:/
says Sphinx >=1.3, the actual implementation does not
support Sphinx >=1.3b1 and 1.3.1.
I have seen Sphinx release notes and source codes for
those versions, and found that up to 1.2.3 used
init_
init_
So to change the code from >=1.3.1 to >1.2.3, it can
more support Sphinx >=1.3b1 and <1.3.1.
Change-Id: Ia73be8111d3af7
Partial-Bug: #1379998
Related-Bug: #1496882
Ian Y. Choi (ianychoi) wrote : | #14 |
IMO, https:/
the mentioned review https:/
Since pbr 1.8.1 is already released and included that fix, I think this bug does not affect anymore.
Just note that my partial bug fix is for more support on Sphinx >=1.3b1 and <1.3.1.
Please change the bug status if those fixes did not solve this bug.
Changed in pbr: | |
status: | In Progress → Fix Released |
Related fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 9fd7aa2cc7fe50f
Author: Dirk Mueller <email address hidden>
Date: Wed Dec 21 23:29:52 2016 +0100
Don't raise exception on missing man pages
The revert in Ia6cfbfe5b10a5b
broke Sphinx 1.3.x support again. Try to fix it for real this
time by avoiding an exception on missing man_pages.
NOTE(dmllr): don't change dict while iterating over it, hopefully
this fixes the gating failure with python 3.5.x
Change-Id: I52d45fa0a0d42d
Related-Bug: 1379998
Added pbr since it looks like we need to change how we call sphinx.
In https:/ /review. openstack. org/127754 I fix the install_command in the oslotest directory.
https:/ /review. openstack. org/#/c/ 127712/ pins the requirement for now.