Old version information should be configurable

Bug #1599260 reported by Andreas Jaeger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Invalid
Undecided
Unassigned
OpenStack Identity (keystone)
Invalid
Undecided
Unassigned
oslosphinx
Fix Released
Undecided
David Stanek

Bug Description

Have a look at http://developer.openstack.org//api-ref/identity/v2/index.html

The version information here makes no sense, we do not have links to old documents for the api at all. These links should not appear. Can we make them configurable, please?

Revision history for this message
Dolph Mathews (dolph) wrote :

Are you referring to the "Other Versions" section on the left column?

tags: added: documentation
Changed in keystone:
status: New → Incomplete
Revision history for this message
David Stanek (dstanek) wrote :

@Dolph, I would guess yes. Those links are bad and a quick look at oslosphinx shows that it automatically generates those links based on the git tags. There doesn't seem to be any easy way to customize this beyond a custom theme.

Three options as I see it:

  1. Make those links configurable in oslosphinx
  2. Publish the older docs
  3. Create a custom theme based on the default theme

Revision history for this message
Andreas Jaeger (jaegerandi) wrote :

Dolph, yes, I'm referring to the "other versions" on the left there.

Changed in keystone:
status: Incomplete → New
Revision history for this message
David Stanek (dstanek) wrote :

Our generated documentation definitely has broken links.

Changed in keystone:
status: New → Confirmed
Revision history for this message
Steve Martinelli (stevemar) wrote :

adding ironic since they have the same problem: http://developer.openstack.org/api-ref/baremetal/index.html

David Stanek (dstanek)
Changed in keystone:
assignee: nobody → David Stanek (dstanek)
Changed in oslosphinx:
assignee: nobody → David Stanek (dstanek)
Changed in keystone:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslosphinx (master)

Fix proposed to branch: master
Review: https://review.openstack.org/340508

Changed in oslosphinx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/340509

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/340515

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
David Stanek (dstanek) wrote :

I've come up with two different ways in oslosphinx to make this configurable. Looking for some feedback on which one to pursue.

https://review.openstack.org/#/c/340508/
https://review.openstack.org/#/c/340509/

Revision history for this message
David Stanek (dstanek) wrote :

This bug is not just for api-ref documentation, but affects anything using the oslosphinx theme. I've made a keystone patch for api-ref and developer documentation that depends on the oslosphinx changes.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslosphinx (master)

Change abandoned by David Stanek (<email address hidden>) on branch: master
Review: https://review.openstack.org/340508
Reason: Going with https://review.openstack.org/#/c/340509 instead

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslosphinx (master)

Reviewed: https://review.openstack.org/340509
Committed: https://git.openstack.org/cgit/openstack/oslosphinx/commit/?id=3bcdfc6b77212ce802763c4fadea0bed08ca42fe
Submitter: Jenkins
Branch: master

commit 3bcdfc6b77212ce802763c4fadea0bed08ca42fe
Author: David Stanek <email address hidden>
Date: Mon Jul 11 16:49:48 2016 +0000

    Allow "Other Versions" section to be configurable

    Adds a new option that allows the "Other Versions" section to be removed
    if a project isn't interested in showing links to older versions. The
    default value is False which means that it will be hidden.

    Even though the setting is not backward compatible there are enough
    broken documentation links in the OpenStack projects that this should be
    opt-in behavior.

    Change-Id: Ic4b47b19aa9db38557c37aed7722174b7dbdf4a1
    Closes-Bug: #1599260

Changed in oslosphinx:
status: In Progress → Fix Released
Revision history for this message
Steve Martinelli (stevemar) wrote :

I believe this is a no-op for keystone and ironic now, we'll automatically pick up the new oslosphinx and it'll be fixed, i'm marking them as invalid

Changed in ironic:
status: New → Invalid
Changed in keystone:
status: In Progress → Invalid
assignee: David Stanek (dstanek) → nobody
importance: Medium → Undecided
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/oslosphinx 4.7.0

This issue was fixed in the openstack/oslosphinx 4.7.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/oslosphinx 4.7.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Steve Martinelli (<email address hidden>) on branch: master
Review: https://review.openstack.org/340515
Reason: https://review.openstack.org/#/c/340509 was merged instead

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslosphinx 4.7.0

This issue was fixed in the openstack/oslosphinx 4.7.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.