oslo.versionedobjects

ObjectListBase only checks child_versions in obj_make_compatible()

Bug #1470617 reported by Ryan Rossiter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.versionedobjects
Fix Released
Undecided
Ryan Rossiter

Bug Description

In order to strengthen relationships in Nova, all of the List objects are moving to use obj_relationships instead of child_versions (https://bugs.launchpad.net/nova/+bug/1470154)

With the move to obj_relationships to replace child_versions, obj_make_compatible() in ObjectListBase (http://git.openstack.org/cgit/openstack/oslo.versionedobjects/tree/oslo_versionedobjects/base.py#n770) now always tries to convert the child objects to version 1.0.

obj_make_compatible() should be checking both child_versions and obj_relationships so the end user can decide which method of relationships they want to use (seeing as obj_relationships functionally reduces to child_versions in the case of only one field 'objects').

Dan Smith (danms)
Changed in oslo.versionedobjects:
status: New → Confirmed
Revision history for this message
Ryan Rossiter (rlrossit) wrote :

Fix merged here: https://review.openstack.org/#/c/203831/

Changed in oslo.versionedobjects:
assignee: nobody → Ryan Rossiter (rlrossit)
status: Confirmed → Fix Committed
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.