strutils.mask_dict_password should accept collections.Mappings
Bug #1804528 reported by
John Dennis
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
oslo.utils |
Fix Released
|
Medium
|
Ben Nemec |
Bug Description
This test at the head of mask_dict_password:
if not isinstance(
raise TypeError("Expected a dictionary, got %s instead."
Is too restrictive, it should accept any mapping object. It is not necessary for the dictionary to be mutable (unlike a dict) because mask_dict_
if not isinstance(
Note, both of these statements below return True
isinstance({}, collections.
isinstance({}, collections.
Changed in oslo.utils: | |
status: | New → Triaged |
importance: | Undecided → Medium |
To post a comment you must log in.
Fix proposed to branch: master /review. openstack. org/620686
Review: https:/