1. There are some problems about the test method.
problem 1:
Unit tests may not cover our function, it depends on the python version
that performed the test.
problem 2:
when using function 'constant_time_compare(first, second)', 'first' and
'second' params are usually HMAC digest values, it is not appropriate to
use utf-8 encoded values as mock data.
2. The previous commit `f1d332a` lead into a bug, but due to the problem 1
and the problem 2, we did not find out the error.
Reviewed: https:/ /review. openstack. org/570151 /git.openstack. org/cgit/ openstack/ oslo.utils/ commit/ ?id=e158c10ccb8 0963ad8009beedf c1fda4a74628d0
Committed: https:/
Submitter: Zuul
Branch: master
commit e158c10ccb80963 ad8009beedfc1fd a4a74628d0
Author: changxun <email address hidden>
Date: Wed May 23 17:13:47 2018 +0800
Fix exception with secretutils
1. There are some problems about the test method. time_compare( first, second)', 'first' and
problem 1:
Unit tests may not cover our function, it depends on the python version
that performed the test.
problem 2:
when using function 'constant_
'second' params are usually HMAC digest values, it is not appropriate to
use utf-8 encoded values as mock data.
2. The previous commit `f1d332a` lead into a bug, but due to the problem 1
and the problem 2, we did not find out the error.
Change-Id: I1c29bfe69f8eda 60f3c5caaf3e544 7dd5b69b108
Closes-Bug: #1772851