oslo.utils

make importutils.import_versioned_module work for consuming projects

Bug #1627313 reported by ChangBo Guo(gcb) on 2016-09-24

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Glance Client	Fix Released	High	liwei
Vitrage Client	Fix Released	Undecided	Tuan
oslo.utils	Fix Released	High	ChangBo Guo(gcb)	oslo.utils 1.7.0 "1.7.0"
python-ceilometerclient	Fix Released	Undecided	Tuan
python-heatclient	Fix Released	Undecided	shizhihui
python-ironicclient	Fix Released	Low	ChangBo Guo(gcb)	python-ironicclient 0.6.0
python-karborclient	Fix Released	Undecided	pawnesh kumar
python-muranoclient	Fix Released	Undecided	Kirill Zaitsev

Bug Description

We hard-code module name in method import_versioned_module as follow:

def import_versioned_module(version, submodule=None):
"""Import a versioned module.

    .. versionadded:: 0.3
    """
    module = 'oslo.v%s' % version
    if submodule:
        module = '.'.join((module, submodule))
    return import_module(module)

But downstream projects can't work and must provide specific version of this method:

http://codesearch.openstack.org/?q=import_versioned_module&i=nope&files=&repos=

ChangBo Guo(gcb) (glongwave) on 2016-09-24

Changed in oslo.utils:
assignee:	nobody → ChangBo Guo(gcb) (glongwave)

Revision history for this message

ChangBo Guo(gcb) (glongwave) wrote on 2016-09-27:

code review in https://review.openstack.org/#/c/375871/

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-19: Fix included in openstack/oslo.utils 3.17.0

This issue was fixed in the openstack/oslo.utils 3.17.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-02: Fix proposed to python-ironicclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/392395

Changed in python-ironicclient:
assignee:	nobody → ChangBo Guo(gcb) (glongwave)
status:	New → In Progress

liwei (wei-li) on 2016-11-02

Changed in python-glanceclient:
assignee:	nobody → liwei (wei-li)

OpenStack Infra (hudson-openstack) on 2016-11-02

Changed in python-glanceclient:
status:	New → In Progress

shizhihui (shizhihui) on 2016-11-02

Changed in python-heatclient:
assignee:	nobody → shizhihui (shizhihui)

LiuNanke (nanke-liu) on 2016-11-02

Changed in python-muranoclient:
assignee:	nobody → LiuNanke (nanke-liu)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-02: Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/392462

Changed in python-heatclient:
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2016-11-02

Changed in python-ceilometerclient:
assignee:	nobody → Tuan (tuanla)
status:	New → In Progress

pawnesh kumar (pawnesh.kumar) on 2016-11-02

Changed in python-karborclient:
assignee:	nobody → pawnesh kumar (pawnesh.kumar)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-02: Fix proposed to python-karborclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/392560

Changed in python-karborclient:
status:	New → In Progress

Dmitry Tantsur (divius) on 2016-11-02

Changed in python-ironicclient:
importance:	Undecided → Low

Tuan (tuanla) on 2016-11-03

Changed in python-vitrageclient:
assignee:	nobody → Tuan (tuanla)

OpenStack Infra (hudson-openstack) on 2016-11-03

Changed in python-vitrageclient:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-03: Fix merged to python-ironicclient (master)

Reviewed: https://review.openstack.org/392395
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=6c71d8771d7ab551ea2cf3e4b0ef8a3b539aed85
Submitter: Jenkins
Branch: master

commit 6c71d8771d7ab551ea2cf3e4b0ef8a3b539aed85
Author: ChangBo Guo(gcb) <email address hidden>
Date: Wed Nov 2 11:22:37 2016 +0800

Use function import_versioned_module from oslo.utils

oslo.utils 3.17 provides similar function, just use it.

Closes-Bug: #1627313

Change-Id: I1710faafd69cb098d603135ca8a158129edb6fec

Changed in python-ironicclient:
status:	In Progress → Fix Released

ChangBo Guo(gcb) (glongwave) on 2016-11-04

Changed in oslo.utils:
status:	New → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-04: Fix merged to python-ceilometerclient (master)

Reviewed: https://review.openstack.org/392514
Committed: https://git.openstack.org/cgit/openstack/python-ceilometerclient/commit/?id=dc7e77989134fcda94934dc96aa8ac1c735bd939
Submitter: Jenkins
Branch: master

commit dc7e77989134fcda94934dc96aa8ac1c735bd939
Author: Luong Anh Tuan <email address hidden>
Date: Wed Nov 2 16:56:05 2016 +0700

Make method import_versioned_module work

    Update function import_versioned_module in Oslo.utils 3.17.
    This patch update to meet new version. For more information:
    http://docs.openstack.org/developer/oslo.utils/history.html

Change-Id: Ia031b53b27fcea66dbf4f2798d58b51c53c2d0cc
Closes-Bug: #1627313

Changed in python-ceilometerclient:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-08: Fix proposed to python-muranoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/394770

Changed in python-muranoclient:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-08: Fix included in openstack/python-ironicclient 1.8.0

This issue was fixed in the openstack/python-ironicclient 1.8.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-09: Fix merged to python-karborclient (master)

#10

Reviewed: https://review.openstack.org/392560
Committed: https://git.openstack.org/cgit/openstack/python-karborclient/commit/?id=fae4ef7a032500bd8592b624bbd2e65fda534fbc
Submitter: Jenkins
Branch: master

commit fae4ef7a032500bd8592b624bbd2e65fda534fbc
Author: pawnesh.kumar <email address hidden>
Date: Wed Nov 2 16:49:12 2016 +0530

Make method import_versioned_module work

    Update function import_versioned_module in Oslo.utils 3.17.
    This patch update to meet new version. For more information:
    http://docs.openstack.org/developer/oslo.utils/history.html

Change-Id: I8b856c4a6a017fdc668326cb18c0b14d6d09ddc2
Closes-Bug: #1627313

Changed in python-karborclient:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-10: Fix included in openstack/python-ironicclient 1.8.0

#11

This issue was fixed in the openstack/python-ironicclient 1.8.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-01: Change abandoned on python-muranoclient (master)

#12

Change abandoned by Nanke_Liu (lnk) (<email address hidden>) on branch: master
Review: https://review.openstack.org/394770

LiuNanke (nanke-liu) on 2016-12-01

Changed in python-muranoclient:
status:	In Progress → Invalid

Hemanth Makkapati (hemanth-makkapati) on 2016-12-06

Changed in python-glanceclient:
importance:	Undecided → Low

Tuan (tuanla) on 2016-12-15

Changed in oslo.utils:
importance:	Undecided → High
milestone:	none → 1.8.0
Changed in python-glanceclient:
importance:	Low → High
Changed in python-muranoclient:
status:	Invalid → Confirmed
Changed in oslo.utils:
milestone:	1.8.0 → 1.7.0
Changed in python-ironicclient:
milestone:	none → 0.6.0

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-16: Fix merged to python-glanceclient (master)

#13

Reviewed: https://review.openstack.org/389580
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=4773c9667251043333d9c3e0c56e9d262186380d
Submitter: Jenkins
Branch: master

commit 4773c9667251043333d9c3e0c56e9d262186380d
Author: Li Wei <email address hidden>
Date: Fri Oct 21 15:57:39 2016 +0800

Use import_versioned_module from oslo.utils

oslo.utils 3.17 provides this funtion, so just use it directly.

Change-Id: I85cb78a6fd33a5b1f7e09648efed1b0737678eee
Closes-Bug: #1627313

Changed in python-glanceclient:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-10: Fix merged to python-heatclient (master)

#14

Reviewed: https://review.openstack.org/392462
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=8885ce78189ac2239ec0400f6fec734627bf1218
Submitter: Jenkins
Branch: master

commit 8885ce78189ac2239ec0400f6fec734627bf1218
Author: shizhihui <email address hidden>
Date: Wed Nov 2 16:09:48 2016 +0800

Make method import_versioned_module work

    Oslo.utils 3.17 provides similar function, just use it.
    For more information:
    [1] http://docs.openstack.org/developer/oslo.utils/history.html

Closes-Bug: #1627313

Change-Id: Ie738e910cc72535fe97295d7e118eda2412ecd15

Changed in python-heatclient:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-11: Fix merged to python-vitrageclient (master)

#15

Reviewed: https://review.openstack.org/392491
Committed: https://git.openstack.org/cgit/openstack/python-vitrageclient/commit/?id=664905565f7efea624630664e7ac56aecd4d3246
Submitter: Jenkins
Branch: master

commit 664905565f7efea624630664e7ac56aecd4d3246
Author: Luong Anh Tuan <email address hidden>
Date: Wed Nov 2 16:24:56 2016 +0700

Make method import_versioned_module work

    Update function import_versioned_module in Oslo.utils 3.17
    This patch update to meet new version. For more information:
    http://docs.openstack.org/developer/oslo.utils/history.html

Change-Id: I9c3ba7acc9b04e766ae4e55f817a5c876a0e8752
Closes-Bug: #1627313

Changed in python-vitrageclient:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-24: Fix included in openstack/python-glanceclient 2.6.0

#16

This issue was fixed in the openstack/python-glanceclient 2.6.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-25: Fix included in openstack/python-heatclient 1.8.0

#17

This issue was fixed in the openstack/python-heatclient 1.8.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-25: Fix included in openstack/python-vitrageclient 1.1.0

#18

This issue was fixed in the openstack/python-vitrageclient 1.1.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-25: Fix included in openstack/python-ceilometerclient 2.8.0

#19

This issue was fixed in the openstack/python-ceilometerclient 2.8.0 release.

OpenStack Infra (hudson-openstack) on 2017-03-14

Changed in python-muranoclient:
assignee:	LiuNanke (nanke-liu) → Kirill Zaitsev (kzaitsev)
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-14: Fix merged to python-muranoclient (master)

#20

Reviewed: https://review.openstack.org/394770
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=6776dd66aca5055d72e0d3283dd4190c8f9555d5
Submitter: Jenkins
Branch: master

commit 6776dd66aca5055d72e0d3283dd4190c8f9555d5
Author: LiuNanke <email address hidden>
Date: Tue Nov 8 14:03:25 2016 +0800

Make method import_versioned_module work

    Oslo.utils 3.17 provides similar function, just use it.
    For more information:
    [1] http://docs.openstack.org/developer/oslo.utils/history.html

Change-Id: I77b0517422569f9ef559b2cf7c7d954713c74de5
Closes-Bug: #1627313

Changed in python-muranoclient:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-06-07: Fix included in openstack/python-muranoclient 0.13.0

#21

This issue was fixed in the openstack/python-muranoclient 0.13.0 release.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.