service thread group graceful is not working

Bug #1769825 reported by TommyLike
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.service
Fix Released
Medium
TommyLike

Bug Description

Graceful exit is not working since we removed the timers before waiting them to complete, see here [1]

[1]: https://github.com/openstack/oslo.service/blob/ccbc263e2ec9028edd532367f1c19ebdb2be0ce6/oslo_service/threadgroup.py#L131

Changed in oslo.service:
assignee: nobody → TommyLike (hu-husheng)
status: New → In Progress
Revision history for this message
Zane Bitter (zaneb) wrote :

Specifically, periodic timers spawned a thread each time the timer is triggered. Calling stop(graceful=True) does not wait for those tasks that may be running to complete before returning. Only tasks created by add_thread(), not add_timer(), are guaranteed to be complete.

Ben Nemec (bnemec)
Changed in oslo.service:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.service (master)

Reviewed: https://review.openstack.org/558418
Committed: https://git.openstack.org/cgit/openstack/oslo.service/commit/?id=20a217817141891615b854936d8d721f2e0973b2
Submitter: Zuul
Branch: master

commit 20a217817141891615b854936d8d721f2e0973b2
Author: TommyLike <email address hidden>
Date: Tue Apr 3 15:39:31 2018 +0800

    [ThreadGroup] Don't remove timer when stop timers

    Graceful exit is not working since we removed the timers
    before waiting them to complete.

    Closes-Bug: #1769825
    Change-Id: I2e52b680a09d337d9b598a4826132df8c7b0b4d9

Changed in oslo.service:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslo.service 1.31.2

This issue was fixed in the openstack/oslo.service 1.31.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.