| 2016-07-19 02:02:45 |
Haifeng.Yan |
bug |
|
|
added bug |
| 2016-07-19 02:51:51 |
Haifeng.Yan |
description |
oslo.config$ grep 'self.assertEqual(self' -r oslo_config/tests/
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'baaar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.newfoo, 'last')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
...
These misplace have 2 issue:
1, confusing message when some tests failed.
2, mislead other developer, new test module may follow these wrong pattern. |
oslo.config$ grep 'self.assertEqual(self' -r oslo_config/tests/
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'baaar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.newfoo, 'last')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
...
These misplaces have 2 issues:
1, giving confusing messages when some tests failed.
2, mislead other developer, new test module may follow these wrong pattern. |
|
| 2016-07-19 03:31:13 |
Haifeng.Yan |
oslo.config: assignee |
|
Haifeng.Yan (yanheven) |
|
| 2016-07-19 03:34:26 |
Haifeng.Yan |
description |
oslo.config$ grep 'self.assertEqual(self' -r oslo_config/tests/
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'baaar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.newfoo, 'last')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
...
These misplaces have 2 issues:
1, giving confusing messages when some tests failed.
2, mislead other developer, new test module may follow these wrong pattern. |
oslo.config$ grep 'self.assertEqual(self' -r oslo_config/tests/
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'baaar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.newfoo, 'last')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
...
it should be assertEqual(expected, actual)
These misplaces have 2 issues:
1, giving confusing messages when some tests failed.
2, mislead other developer, new test module may follow these wrong pattern. |
|
| 2016-07-19 03:42:00 |
Haifeng.Yan |
description |
oslo.config$ grep 'self.assertEqual(self' -r oslo_config/tests/
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'baaar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.newfoo, 'last')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
...
it should be assertEqual(expected, actual)
These misplaces have 2 issues:
1, giving confusing messages when some tests failed.
2, mislead other developer, new test module may follow these wrong pattern. |
oslo.config$ grep 'self.assertEqual(self' -r oslo_config/tests/
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'baaar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.newfoo, 'last')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
...
it should be assertEqual(expected, actual)
These misplaces have 2 issues:
1, giving confusing messages when some tests failed.
2, mislead other developers, new test modules may follow these wrong pattern. |
|
| 2016-07-19 03:53:31 |
OpenStack Infra |
oslo.config: status |
New |
In Progress |
|
| 2016-07-19 03:59:25 |
Haifeng.Yan |
description |
oslo.config$ grep 'self.assertEqual(self' -r oslo_config/tests/
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'baaar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.newfoo, 'last')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
...
it should be assertEqual(expected, actual)
These misplaces have 2 issues:
1, giving confusing messages when some tests failed.
2, mislead other developers, new test modules may follow these wrong pattern. |
oslo.config$ grep 'self.assertEqual(self' -r oslo_config/tests/
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'baaar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.newfoo, 'last')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
...
it should be assertEqual(expected, actual)
These misplaces have 2 impacts:
1, giving confusing messages when some tests failed.
2, mislead other developers, new test modules may follow these wrong pattern. |
|
| 2016-07-19 11:25:50 |
OpenStack Infra |
oslo.config: status |
In Progress |
Fix Released |
|
| 2016-07-20 02:05:49 |
Haifeng.Yan |
bug task added |
|
oslo.log |
|
| 2016-07-20 02:11:00 |
OpenStack Infra |
oslo.log: status |
New |
In Progress |
|
| 2016-07-20 02:11:00 |
OpenStack Infra |
oslo.log: assignee |
|
Haifeng.Yan (yanheven) |
|
| 2016-07-20 02:50:57 |
Haifeng.Yan |
bug task added |
|
oslo.service |
|
| 2016-07-20 03:32:16 |
Haifeng.Yan |
bug task added |
|
oslo.messaging |
|
| 2016-07-20 04:19:55 |
Haifeng.Yan |
oslo.messaging: assignee |
|
Haifeng.Yan (yanheven) |
|
| 2016-07-20 04:19:57 |
Haifeng.Yan |
oslo.service: assignee |
|
Haifeng.Yan (yanheven) |
|
| 2016-07-20 10:09:16 |
Haifeng.Yan |
bug task added |
|
oslo.db |
|
| 2016-07-20 10:09:24 |
Haifeng.Yan |
oslo.db: assignee |
|
Haifeng.Yan (yanheven) |
|
| 2016-07-21 02:34:01 |
OpenStack Infra |
oslo.messaging: status |
New |
In Progress |
|
| 2016-07-21 17:46:08 |
Roman Podoliaka |
oslo.db: importance |
Undecided |
Low |
|
| 2016-07-21 17:46:12 |
Roman Podoliaka |
oslo.db: status |
New |
Confirmed |
|
| 2016-07-21 19:24:04 |
OpenStack Infra |
oslo.log: status |
In Progress |
Fix Released |
|
| 2016-07-22 02:23:15 |
Haifeng.Yan |
oslo.service: status |
New |
Fix Released |
|
| 2016-07-22 03:49:25 |
Haifeng.Yan |
bug task added |
|
oslotest |
|
| 2016-07-22 03:59:32 |
Haifeng.Yan |
oslotest: assignee |
|
Haifeng.Yan (yanheven) |
|
| 2016-07-22 16:16:51 |
Haifeng.Yan |
bug task added |
|
oslo.middleware |
|
| 2016-07-22 16:16:58 |
Haifeng.Yan |
oslo.middleware: assignee |
|
Haifeng.Yan (yanheven) |
|
| 2016-07-22 17:22:48 |
Haifeng.Yan |
bug task added |
|
oslo.concurrency |
|
| 2016-07-22 17:23:01 |
Haifeng.Yan |
oslo.concurrency: assignee |
|
Haifeng.Yan (yanheven) |
|
| 2016-07-23 09:01:54 |
Haifeng.Yan |
bug task added |
|
oslo.context |
|
| 2016-07-23 09:43:24 |
Haifeng.Yan |
oslo.context: assignee |
|
Haifeng.Yan (yanheven) |
|
| 2016-07-23 11:37:54 |
Haifeng.Yan |
bug task added |
|
oslo.serialization |
|
| 2016-07-23 11:52:54 |
Haifeng.Yan |
bug task added |
|
oslo.i18n |
|
| 2016-07-24 04:04:02 |
Haifeng.Yan |
oslo.serialization: assignee |
|
Haifeng.Yan (yanheven) |
|
| 2016-07-24 04:04:12 |
Haifeng.Yan |
oslo.i18n: assignee |
|
Haifeng.Yan (yanheven) |
|
| 2016-07-25 06:54:37 |
Haifeng.Yan |
oslo.serialization: status |
New |
Fix Released |
|
| 2016-07-25 06:54:56 |
Haifeng.Yan |
oslo.concurrency: status |
New |
Fix Released |
|
| 2016-07-26 12:43:25 |
OpenStack Infra |
oslo.messaging: status |
In Progress |
Fix Released |
|
| 2016-08-01 07:53:29 |
Haifeng.Yan |
oslotest: status |
New |
Fix Released |
|
| 2016-08-02 08:06:02 |
Haifeng.Yan |
bug task added |
|
oslo.rootwrap |
|
| 2016-08-02 08:07:08 |
Haifeng.Yan |
oslo.rootwrap: assignee |
|
Haifeng.Yan (yanheven) |
|
| 2016-08-04 13:37:14 |
OpenStack Infra |
oslo.rootwrap: status |
New |
Fix Released |
|
| 2016-08-18 02:49:16 |
OpenStack Infra |
tags |
|
in-feature-amqp-dispatch-router |
|
| 2016-08-19 02:08:24 |
Haifeng.Yan |
oslo.context: status |
New |
Fix Released |
|
| 2016-08-19 02:08:37 |
Haifeng.Yan |
oslo.middleware: status |
New |
Fix Released |
|
| 2016-08-19 02:08:52 |
Haifeng.Yan |
oslo.i18n: status |
New |
Fix Released |
|
| 2016-08-19 02:09:01 |
Haifeng.Yan |
oslo.db: status |
Confirmed |
Fix Released |
|
