when rootwrap daemon is timeout and quite, parent progress doesn't reap it

Bug #1850241 reported by Jeffrey Zhang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.rootwrap
Fix Released
Undecided
Jeffrey Zhang

Bug Description

42435 346330 0.7 0.0 340740 130820 ? S Oct24 55:35 | \_ /usr/bin/python2 /usr/bin/neutron-openvswitch-agent --config-file /usr/share/neutron/neutron-dist.conf --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/openvswitch_agent.ini --config-dir /etc/neutron/conf.d/common --log-file=/var/log/neutron/openvswitch-agent.log
root 346424 0.0 0.0 0 0 ? Z Oct24 0:00 | \_ [sudo] <defunct>
42435 346439 0.0 0.0 52652 2836 ? S Oct24 0:12 | \_ ovsdb-client monitor tcp:127.0.0.1:6640 Interface name,ofport,external_ids --format=json
42435 346441 0.0 0.0 52652 2836 ? S Oct24 0:11 | \_ ovsdb-client monitor tcp:127.0.0.1:6640 Bridge name --format=json

in our environment, the rootwrap daemon in neutron-openvswitch-agent will be timeout after a period of time. check this patch for detail[0].

The parent of rootwrap should wait and reap the process when it is exit.

* [0] https://review.opendev.org/#/c/438816/3

Changed in oslo.rootwrap:
assignee: nobody → Jeffrey Zhang (jeffrey4l)
status: New → In Progress
Revision history for this message
Jeffrey Zhang (jeffrey4l) wrote :

fixed is pushed to gerrit

https://review.opendev.org/691672

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.rootwrap (master)

Reviewed: https://review.opendev.org/691672
Committed: https://git.openstack.org/cgit/openstack/oslo.rootwrap/commit/?id=c9a57aab082f55d525f003db61290b6ab7437b7c
Submitter: Zuul
Branch: master

commit c9a57aab082f55d525f003db61290b6ab7437b7c
Author: Jeffrey Zhang <email address hidden>
Date: Mon Oct 28 21:26:59 2019 +0800

    reap rootwrap daemon process when it is timeout

    When the daemon process is timeout, it will kill itself. But the parent
    doesn't reap it. This patch add a thread to wait the process to be done
    once the daemon is started.

    Closes-Bug: #1850241
    Change-Id: Ic209b8ef86c2522ce7e4bd81ac57bf13f1706a81

Changed in oslo.rootwrap:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslo.rootwrap 5.17.1

This issue was fixed in the openstack/oslo.rootwrap 5.17.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.rootwrap (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/oslo.rootwrap/+/805898

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.rootwrap (stable/train)

Reviewed: https://review.opendev.org/c/openstack/oslo.rootwrap/+/805898
Committed: https://opendev.org/openstack/oslo.rootwrap/commit/4f0cf26de8f4cc203eda8dff42d23805513c2f97
Submitter: "Zuul (22348)"
Branch: stable/train

commit 4f0cf26de8f4cc203eda8dff42d23805513c2f97
Author: Jeffrey Zhang <email address hidden>
Date: Mon Oct 28 21:26:59 2019 +0800

    reap rootwrap daemon process when it is timeout

    When the daemon process is timeout, it will kill itself. But the parent
    doesn't reap it. This patch add a thread to wait the process to be done
    once the daemon is started.

    Closes-Bug: #1850241
    Change-Id: Ic209b8ef86c2522ce7e4bd81ac57bf13f1706a81
    (cherry picked from commit c9a57aab082f55d525f003db61290b6ab7437b7c)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslo.rootwrap train-eol

This issue was fixed in the openstack/oslo.rootwrap train-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.