oslo.rootwrap

parameters of assertEqual are misplaced

Bug #1604213 reported by Haifeng.Yan on 2016-07-19

This bug affects 1 person

	Status	Importance	Assigned to
oslo.concurrency	Fix Released	Undecided	Haifeng.Yan
oslo.config	Fix Released	Undecided	Haifeng.Yan
oslo.context	Fix Released	Undecided	Haifeng.Yan
oslo.db	Fix Released	Low	Haifeng.Yan
oslo.i18n	Fix Released	Undecided	Haifeng.Yan
oslo.log	Fix Released	Undecided	Haifeng.Yan
oslo.messaging	Fix Released	Undecided	Haifeng.Yan
oslo.middleware	Fix Released	Undecided	Haifeng.Yan
oslo.rootwrap	Fix Released	Undecided	Haifeng.Yan
oslo.serialization	Fix Released	Undecided	Haifeng.Yan
oslo.service	Fix Released	Undecided	Haifeng.Yan
oslotest	Fix Released	Undecided	Haifeng.Yan

Bug Description

oslo.config$ grep 'self.assertEqual(self' -r oslo_config/tests/

oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'baaar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.newfoo, 'last')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
...

it should be assertEqual(expected, actual)

These misplaces have 2 impacts:
1, giving confusing messages when some tests failed.
2, mislead other developers, new test modules may follow these wrong pattern.

See original description

Tags:

Haifeng.Yan (yanheven) on 2016-07-19

description:

updated

Haifeng.Yan (yanheven) on 2016-07-19

Changed in oslo.config:
assignee:	nobody → Haifeng.Yan (yanheven)
description:	updated

Haifeng.Yan (yanheven) on 2016-07-19

description:

updated

OpenStack Infra (hudson-openstack) on 2016-07-19

Changed in oslo.config:
status:	New → In Progress

Haifeng.Yan (yanheven) on 2016-07-19

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-19: Fix merged to oslo.config (master)

Reviewed: https://review.openstack.org/344003
Committed: https://git.openstack.org/cgit/openstack/oslo.config/commit/?id=61224ce932a520367f8836adbb2220e29b73d54a
Submitter: Jenkins
Branch: master

commit 61224ce932a520367f8836adbb2220e29b73d54a
Author: yan.haifeng <email address hidden>
Date: Tue Jul 19 11:46:45 2016 +0800

Fix parameters of assertEqual are misplaced

Many assertEqual sentences don't follow assertEqual(expected, actual),
this patch fix all of them.

Change-Id: Ia2fbad7a952039fbba4cddc3308721a19dd099d1
Closes-Bug: 1604213

Changed in oslo.config:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-20: Fix proposed to oslo.log (master)

Fix proposed to branch: master
Review: https://review.openstack.org/344535

Changed in oslo.log:
assignee:	nobody → Haifeng.Yan (yanheven)
status:	New → In Progress

Revision history for this message

Haifeng.Yan (yanheven) wrote on 2016-07-20:

I really want to correct all of these wrong usage in all oslo project, because I have reviewed some patches, the new added codes follow this wrong pattern.

Haifeng.Yan (yanheven) on 2016-07-20

Changed in oslo.messaging:
assignee:	nobody → Haifeng.Yan (yanheven)
Changed in oslo.service:
assignee:	nobody → Haifeng.Yan (yanheven)

Haifeng.Yan (yanheven) on 2016-07-20

Changed in oslo.db:
assignee:	nobody → Haifeng.Yan (yanheven)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-21: Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/345131

Changed in oslo.messaging:
status:	New → In Progress

Roman Podoliaka (rpodolyaka) on 2016-07-21

Changed in oslo.db:
importance:	Undecided → Low
status:	New → Confirmed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-21: Fix merged to oslo.log (master)

Reviewed: https://review.openstack.org/344535
Committed: https://git.openstack.org/cgit/openstack/oslo.log/commit/?id=92b6ff6c260007ba84c2d0117e6ed28524f0f1a1
Submitter: Jenkins
Branch: master

commit 92b6ff6c260007ba84c2d0117e6ed28524f0f1a1
Author: yan.haifeng <email address hidden>
Date: Wed Jul 20 10:09:04 2016 +0800

Fix parameters of assertEqual are misplaced

Many assertEqual sentences don't follow assertEqual(expected, actual),
this patch fix all of them.

Closes-Bug: 1604213

Change-Id: I830435ab860c7298cea64a24ef01df3e5326d00c

Changed in oslo.log:
status:	In Progress → Fix Released

Revision history for this message

Haifeng.Yan (yanheven) wrote on 2016-07-22:

Reviewed: https://review.openstack.org/#/c/344543/
Committed: https://git.openstack.org/cgit/openstack/oslo.service/commit/?id=aac1d89dcaf942760ca57c38e2a49e6bf7793666
Submitter: Jenkins
Branch: master

commit aac1d89dcaf942760ca57c38e2a49e6bf7793666
Author: yan.haifeng <email address hidden>
Date: Wed Jul 20 10:49:42 2016 +0800

Fix parameters of assertEqual are misplaced

Many assertEqual sentences don't follow assertEqual(expected, actual),
this patch fix all of them.

Closes-Bug: 1604213
Change-Id: Ice72233f41d2ee1a32ef1be7ff65a8a2ea19c508

Changed in oslo.service:
status:	New → Fix Released

Haifeng.Yan (yanheven) on 2016-07-22

Changed in oslotest:
assignee:	nobody → Haifeng.Yan (yanheven)

Haifeng.Yan (yanheven) on 2016-07-22

Changed in oslo.middleware:
assignee:	nobody → Haifeng.Yan (yanheven)

Haifeng.Yan (yanheven) on 2016-07-22

Changed in oslo.concurrency:
assignee:	nobody → Haifeng.Yan (yanheven)

Haifeng.Yan (yanheven) on 2016-07-23

Changed in oslo.context:
assignee:	nobody → Haifeng.Yan (yanheven)

Haifeng.Yan (yanheven) on 2016-07-24

Changed in oslo.serialization:
assignee:	nobody → Haifeng.Yan (yanheven)
Changed in oslo.i18n:
assignee:	nobody → Haifeng.Yan (yanheven)

Revision history for this message

Haifeng.Yan (yanheven) wrote on 2016-07-25:

oslo.serialization Merged https://review.openstack.org/#/c/346372/
oslo.concurrencyMerged https://review.openstack.org/#/c/346142/

Changed in oslo.serialization:
status:	New → Fix Released
Changed in oslo.concurrency:
status:	New → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-26: Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/345131
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=9ed95bbdc979f8fd5a21469ea3e4866b6d522cfe
Submitter: Jenkins
Branch: master

commit 9ed95bbdc979f8fd5a21469ea3e4866b6d522cfe
Author: yan.haifeng <email address hidden>
Date: Wed Jul 20 14:05:48 2016 +0800

Fix parameters of assertEqual are misplaced

    Many assertEqual sentences don't follow assertEqual(expected, actual),
    These misplaces have 2 impacts:
    1, giving confusing messages when some tests failed.
    2, mislead other developers, new test modules may follow these wrong pattern.

This patch fix all of them.

Change-Id: Icc6e404dd02fe47b76c7366d31d91c8d8e464f54
Closes-Bug: #1604213

Changed in oslo.messaging:
status:	In Progress → Fix Released

Revision history for this message

Haifeng.Yan (yanheven) wrote on 2016-08-01:

patch merged https://review.openstack.org/345753

Changed in oslotest:
status:	New → Fix Released

Haifeng.Yan (yanheven) on 2016-08-02

Changed in oslo.rootwrap:
assignee:	nobody → Haifeng.Yan (yanheven)

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-08-02: Fix included in openstack/oslo.concurrency 3.13.0

#10

This issue was fixed in the openstack/oslo.concurrency 3.13.0 release.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-08-02: Fix included in openstack/oslo.config 3.14.0

#11

This issue was fixed in the openstack/oslo.config 3.14.0 release.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-08-02: Fix included in openstack/oslo.log 3.13.0

#12

This issue was fixed in the openstack/oslo.log 3.13.0 release.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-08-02: Fix included in openstack/oslo.messaging 5.6.0

#13

This issue was fixed in the openstack/oslo.messaging 5.6.0 release.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-08-02: Fix included in openstack/oslo.serialization 2.12.0

#14

This issue was fixed in the openstack/oslo.serialization 2.12.0 release.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-08-02: Fix included in openstack/oslo.service 1.14.0

#15

This issue was fixed in the openstack/oslo.service 1.14.0 release.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-08-02: Fix included in openstack/oslotest 2.8.0

#16

This issue was fixed in the openstack/oslotest 2.8.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-08-04: Fix merged to oslo.rootwrap (master)

#17

Reviewed: https://review.openstack.org/349819
Committed: https://git.openstack.org/cgit/openstack/oslo.rootwrap/commit/?id=a46b731c8a346d9bbb0c461a64aa3fb970123c86
Submitter: Jenkins
Branch: master

commit a46b731c8a346d9bbb0c461a64aa3fb970123c86
Author: yan.haifeng <email address hidden>
Date: Mon Aug 1 11:46:55 2016 +0800

Fix parameters of assertEqual are misplaced

This patch fix all of them.

Change-Id: I4adfc98d6eecd5ea117d725775b2476b237212d9
Closes-Bug: #1604213

Changed in oslo.rootwrap:
status:	New → Fix Released

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-08-10: Fix included in openstack/oslo.rootwrap 5.1.0

#18

This issue was fixed in the openstack/oslo.rootwrap 5.1.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-08-17: Fix proposed to oslo.messaging (feature/amqp-dispatch-router)

#19

Fix proposed to branch: feature/amqp-dispatch-router
Review: https://review.openstack.org/356468

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-08-18: Fix merged to oslo.messaging (feature/amqp-dispatch-router)

#20

Download full text (16.1 KiB)

Reviewed: https://review.openstack.org/356468
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=39c3901b8c1709a197915f12767737298da1d80c
Submitter: Jenkins
Branch: feature/amqp-dispatch-router

commit ee8fff03d989e1a73068262d072f483b8c779163
Author: OpenStack Proposal Bot <email address hidden>
Date: Fri Aug 12 00:24:13 2016 +0000

Updated from global requirements

Change-Id: Ibef43ee38fc395b3d9d55f5e0f820e5c0d0308b1

commit 20a07e7f480ec434cb06cf13156d7c785f70b414
Author: Gevorg Davoian <email address hidden>
Date: Wed Jul 6 11:49:01 2016 +0300

[zmq] Implement retries for unacknowledged CASTs

This patch tries to implement a mechanism of acknowledgements and
retries via proxy for CAST messages.

    Change-Id: I83919382262b9f169becd09f5db465a01a0ccb78
    Partial-Bug: #1497306
    Closes-Bug: #1515269

commit 7c5d039fd355e60e099a0a36408c85a08bfcc2ad
Author: Oleksii Zamiatin <email address hidden>
Date: Thu Aug 4 15:31:45 2016 +0300

Move zmq driver options into its own group

    ZeroMQ driver options are current stored into the DEFAULT group.
    This change makes the zmq configuration clearer by putting its
    options into oslo_messaging_zmq group.

    Change-Id: Ia00fda005b1664750d2646f8c82ebdf295b156fb
    Closes-bug: #1417040
    Co-Authored-By: Oleksii Zamiatin <email address hidden>

commit 51652c57d2b6fa040a0b88d20bafc0026253a516
Author: OpenStack Proposal Bot <email address hidden>
Date: Thu Aug 4 02:40:46 2016 +0000

Updated from global requirements

Change-Id: I5b87131404d34b69dab22564eccb8f1e1a141761

commit 2003a52a16105b22bb3696ccc4aac9b1b561f8bd
Author: OpenStack Proposal Bot <email address hidden>
Date: Wed Aug 3 09:06:36 2016 +0000

Updated from global requirements

Change-Id: Ibdebbd59e62297de8ddd6fbec7743e3c66d1108f

commit d946fb1862dacf3569d7d47759427d1460b64d11
Author: Gevorg Davoian <email address hidden>
Date: Tue Jul 19 12:53:27 2016 +0300

Fix pika functional tests

    Change-Id: I05f2cbd914857da7a75ca068e99614156797d1ed
    Closes-Bug: #1599777
    Depends-On: Ic6acc5d006344e08c219724e488fc9222786d849

commit 9e61efa67d2d461626f79c1937dec6c50499568f
Author: ozamiatin <email address hidden>
Date: Tue Jul 26 12:52:11 2016 +0300

[zmq] Use zmq.IMMEDIATE option for round-robin

    This options helps to prevent message loss by scheduling
    messages only to a connected queue. If there is no connections
    socket hangs waiting.

Change-Id: I87b97c8b77887f53599a28e0d05fc2c71c149499
Closes-Bug: #1606272

commit 75764971962252ffd2720036e3b564b5d0ae76f1
Author: maoshuai <fwsakura@163.com>
Date: Fri Jul 29 10:59:34 2016 +0800

fix a typo in impl_rabbit.py

Change-Id: I75f99d7e3a6b193e30d8d9baad6a939fbdd0ca6d

commit 12886219a6855a109609aaf009a96a9a2a19ffd2
Author: OpenStack Proposal Bot <email address hidden>
Date: Fri Jul 29 02:33:54 2016 +0000

Updated from global requirements

Change-Id: Iae11896324f16164fd62a53c089ebd2948437098

commit 317641c42f006eaec644c3524da63b63ab6771e1
Autho...

Reviewed:  https://review.openstack.org/356468
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=39c3901b8c1709a197915f12767737298da1d80c
Submitter: Jenkins
Branch:    feature/amqp-dispatch-router

commit ee8fff03d989e1a73068262d072f483b8c779163
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Fri Aug 12 00:24:13 2016 +0000

Updated from global requirements
    
    Change-Id: Ibef43ee38fc395b3d9d55f5e0f820e5c0d0308b1

commit 20a07e7f480ec434cb06cf13156d7c785f70b414
Author: Gevorg Davoian <gdavoian@mirantis.com>
Date:   Wed Jul 6 11:49:01 2016 +0300

[zmq] Implement retries for unacknowledged CASTs
    
    This patch tries to implement a mechanism of acknowledgements and
    retries via proxy for CAST messages.
    
    Change-Id: I83919382262b9f169becd09f5db465a01a0ccb78
    Partial-Bug: #1497306
    Closes-Bug: #1515269

commit 7c5d039fd355e60e099a0a36408c85a08bfcc2ad
Author: Oleksii Zamiatin <ozamiatin@mirantis.com>
Date:   Thu Aug 4 15:31:45 2016 +0300

Move zmq driver options into its own group
    
    ZeroMQ driver options are current stored into the DEFAULT group.
    This change makes the zmq configuration clearer by putting its
    options into oslo_messaging_zmq group.
    
    Change-Id: Ia00fda005b1664750d2646f8c82ebdf295b156fb
    Closes-bug: #1417040
    Co-Authored-By: Oleksii Zamiatin <ozamiatin@mirantis.com>

commit 51652c57d2b6fa040a0b88d20bafc0026253a516
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Thu Aug 4 02:40:46 2016 +0000

Updated from global requirements
    
    Change-Id: I5b87131404d34b69dab22564eccb8f1e1a141761

commit 2003a52a16105b22bb3696ccc4aac9b1b561f8bd
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Wed Aug 3 09:06:36 2016 +0000

Updated from global requirements
    
    Change-Id: Ibdebbd59e62297de8ddd6fbec7743e3c66d1108f

commit d946fb1862dacf3569d7d47759427d1460b64d11
Author: Gevorg Davoian <gdavoian@mirantis.com>
Date:   Tue Jul 19 12:53:27 2016 +0300

Fix pika functional tests
    
    Change-Id: I05f2cbd914857da7a75ca068e99614156797d1ed
    Closes-Bug: #1599777
    Depends-On: Ic6acc5d006344e08c219724e488fc9222786d849

commit 9e61efa67d2d461626f79c1937dec6c50499568f
Author: ozamiatin <ozamiatin@mirantis.com>
Date:   Tue Jul 26 12:52:11 2016 +0300

[zmq] Use zmq.IMMEDIATE option for round-robin
    
    This options helps to prevent message loss by scheduling
    messages only to a connected queue. If there is no connections
    socket hangs waiting.
    
    Change-Id: I87b97c8b77887f53599a28e0d05fc2c71c149499
    Closes-Bug: #1606272

commit 75764971962252ffd2720036e3b564b5d0ae76f1
Author: maoshuai <fwsakura@163.com>
Date:   Fri Jul 29 10:59:34 2016 +0800

fix a typo in impl_rabbit.py
    
    Change-Id: I75f99d7e3a6b193e30d8d9baad6a939fbdd0ca6d

commit 12886219a6855a109609aaf009a96a9a2a19ffd2
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Fri Jul 29 02:33:54 2016 +0000

Updated from global requirements
    
    Change-Id: Iae11896324f16164fd62a53c089ebd2948437098

commit 317641c42f006eaec644c3524da63b63ab6771e1
Author: Gregory Haynes <greg@greghaynes.net>
Date:   Thu Jul 28 01:56:48 2016 +0000

Fix syntax error on notification listener docs
    
    We are missing a list delimiter in our docs example for a notification
    listener.
    
    Change-Id: Ib8b9c35e7bff241bf8473a98a2ee188da7e194e4

commit a6f0aaed3ff2e2ce40665d4e90e92da9d3b3c753
Author: Kirill Bespalov <kbespalov@mirantis.com>
Date:   Mon Jul 25 15:11:53 2016 +0300

Delete fanout queues on gracefully shutdown
    
    No reasons to kept fanout queues in case then
    a rpc server is gracefully shutdown. The expiration
    time of the fanout queue is too long (30 mins), so for
    large scales it can accumulate a lot of messages before it be removed
    
    Closes-Bug: 1606213
    Change-Id: Ieaa35c454df542042f3a5424d70f87d486693024

commit 564e423d24512b7eb3a832746e986cd5d8268ef2
Author: Gevorg Davoian <gdavoian@mirantis.com>
Date:   Sun Jul 24 19:12:23 2016 +0300

Properly cleanup listener and driver on simulator exit
    
    Change-Id: Id04d4d1ce131bf7a4681273c438cbe6e58b44e78
    Closes-Bug: #1584743
    Co-Authored-By: Oleksii Zamiatin <ozamiatin@mirantis.com>

commit 18c8bc933dc6c55af4eaaa755e5198d89ad54468
Author: Oleksii Zamiatin <ozamiatin@mirantis.com>
Date:   Fri Jul 15 15:10:30 2016 +0300

[zmq] Let proxy serve on a static port numbers
    
    Currently proxy binds to a random port from a port range
    specified in zmq config and therefore needs to register in
    redis to become visible to clients and servers.
    
    That could be done much simpler by using a static port(s) for
    proxy. Moreover zmq handles reconnect to a socket if restarted
    service uses the same port number as it had before restart.
    
    Change-Id: I088792fd08a4161d08e9160830fc3ec4d560cca4

commit 162f6e987b92d609b0e6187ddfc1f40dca88e400
Author: Kirill Bespalov <kbespalov@mirantis.com>
Date:   Mon Jul 11 15:25:23 2016 +0300

Introduce TTL for idle connections
    
    We can reduce a workload of rabbitmq through implementation
    of expiration mechanism for idle connections in the pool with
    next properties:
    
     conn_pool_ttl (default 20 min)
     conn_pool_min_size: the pool size limit for expire() (default 2)
    
    The problem is timeless idle connections in the pool, which can be created
    via some single huge workload of RPCServer. One SEND connection is heartbeat
    thread + some network activity every n second. So, we can reduce it.
    
    Here is two ways to implement an expiration:
    
     [1] Create a separated thread for checking expire date of connections
     [2] Make call expire() on pool.get() or pool.put()
    
    The [1] has some threading overhead, but probably insignificant
    because the thread can sleep 99% time and wake up every 20 mins (by default).
    Anyway current implementation is [2].
    
    Change-Id: Ie8781d10549a044656824ceb78b2fe2e4f7f8b43

commit 9ed95bbdc979f8fd5a21469ea3e4866b6d522cfe
Author: yan.haifeng <yanheven@qq.com>
Date:   Wed Jul 20 14:05:48 2016 +0800

Fix parameters of assertEqual are misplaced
    
    Many assertEqual sentences don't follow assertEqual(expected, actual),
    These misplaces have 2 impacts:
    1, giving confusing messages when some tests failed.
    2, mislead other developers, new test modules may follow these wrong pattern.
    
    This patch fix all of them.
    
    Change-Id: Icc6e404dd02fe47b76c7366d31d91c8d8e464f54
    Closes-Bug: #1604213

commit 95d04028747b1f335ef52d5b204f10e7a10ab023
Author: Edu Alcaniz <ealcaniz@redhat.com>
Date:   Tue Jul 5 12:34:03 2016 +0200

Fix misstyping issue
    
    Change-Id: I5f6ed9e021c2f218046ea6fed55e58018b595392

commit d1cbca851b1ef9d099a22d9c58a35165710687c8
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Tue Jul 19 15:19:58 2016 +0000

Updated from global requirements
    
    Change-Id: I7e0a79888c46869c6b7deeda7e7aaeb877c8873d

commit 73b3286eee2fb01a2bae427681ca6d71ab955224
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Fri Jul 15 03:46:40 2016 +0000

Updated from global requirements
    
    Change-Id: Ib89194bdf72da24309f398016b73ee9d67885c39

commit ff9b4bb938dcc7cdd8c7fa4d2fe716f4c33a9ca6
Author: Julien Danjou <julien@danjou.info>
Date:   Fri Jul 1 17:06:09 2016 +0200

notify: add a CLI tool to manually send notifications
    
    Change-Id: I01ebd8402e322c5c27dc2fc4c61fb5beb2dddae8

commit 538c84b300d8d941d07d600303ad6c75d9e08a99
Author: Joshua Harlow <jxharlow@godaddy.com>
Date:   Tue Jul 12 11:06:55 2016 -0700

Add deprecated relnote for max_retries rabbit configuration option
    
    Change-Id: I3e7fbededc972c5c785c037e2abd7ccff0aae267

commit ae1123e438ef0c3a1abe427afe3ed1c4c5e727be
Author: Oleksii Zamiatin <ozamiatin@mirantis.com>
Date:   Tue Jul 12 15:17:27 2016 +0300

[zmq] Add py34 configuration for functional tests
    
    Change-Id: I6bd94323d88ce9123776b1359696fbc2e31933de
    Closes-Bug: #1602234

commit 07187f9bacd44480b45a06a97d5d42aebad19a64
Author: Gevorg Davoian <gdavoian@mirantis.com>
Date:   Tue Jul 12 18:42:45 2016 +0300

[zmq] Merge publishers
    
    This patch merges small logically related publishers supporting
    only some messaging patterns into bigger ones supporting all
    messaging patterns at once.
    
    Change-Id: Ic47e4d89166dd14f8a67101e666dc780a1ccb2a8

commit 8e778658e527b760cfd6b95063b16b356d3bac07
Author: ChangBo Guo(gcb) <eric.guo@easystack.cn>
Date:   Tue Jul 12 16:35:36 2016 +0800

Add Python 3.5 classifier and venv
    
    Now that there is a passing gate job, we can claim support for
    Python 3.5 in the classifier. This patch also adds the convenience
    py35 venv.
    
    Change-Id: I8871f4e17ab806c00661d0c960a216d0a3fc5449

commit 689ba081730b7a9adb3f50240921a682b82839dd
Author: weiweigu <gu.weiwei@zte.com.cn>
Date:   Tue Jul 12 12:01:23 2016 +0800

Replace assertEqual(None, *) with assertIsNone in tests
    
    Replace assertEqual(None, *) with assertIsNone in tests to have more
    clear messages in case of failure.
    
    Change-Id: Idb0376964ecc65d04e5b79753efd8f6a0b822bf8
    Closes-Bug: #1280522

commit c6c70aba2dfb00d50c9415db8cb01794d0ad62c7
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Sat Jul 9 19:25:54 2016 +0000

Updated from global requirements
    
    Change-Id: I3d565fabb11b45c6420ed80c81504886b53b99c7

commit 66ded1f91426e80e48cb2e0aa84c50beabe5153e
Author: Gevorg Davoian <gdavoian@mirantis.com>
Date:   Mon Jul 4 20:09:30 2016 +0300

[zmq] Use json/msgpack instead of pickle
    
    Change-Id: Ia4a08b6f2d932ad0642d64f55bcdadef814e4350
    Closes-Bug: #1582207
    Closes-Bug: #1584763
    Depends-On: I90df59d61af2b40b516a5151c67c184fcc91e366

commit ac484f6b26c6509549edc1150673915b48482ac2
Author: Gevorg Davoian <gdavoian@mirantis.com>
Date:   Wed Jun 22 19:09:32 2016 +0300

[zmq] Refactor publishers
    
    This patch refactors publishers by separating responsibilities and
    introducing senders and waiters within publishers.
    
    Change-Id: I90df59d61af2b40b516a5151c67c184fcc91e366
    Co-Authored-By: Oleksii Zamiatin <ozamiatin@mirantis.com>

commit 96438a3e1fa90aa09651573196ee996136b505f8
Author: Kenneth Giusti <kgiusti@gmail.com>
Date:   Fri Jul 1 13:44:25 2016 -0400

Add Python 3.4 functional tests for AMQP 1.0 driver
    
    Change-Id: Ieead11641df3e711555420517e9668258a79410b
    Closes-Bug: #1598209

commit 35146383d00690f3f31dabf1ad2dbac56b6bc319
Author: Mehdi Abaakouk <sileht@redhat.com>
Date:   Thu Apr 7 10:35:18 2016 +0200

tests: allow to override the functionnal tests suite args
    
    Change-Id: Ia958b3812be7c51a07734081542f14452c5de658

commit 2b50ea5a3046f5f72e90d1c9841453aa9d38767e
Author: Oleksii Zamiatin <ozamiatin@mirantis.com>
Date:   Mon Jul 4 12:28:57 2016 +0300

[zmq] Additional configurations for f-tests
    
    Extend functional testing to cover all zmq deployment configurations.
    
    Change-Id: I03a1bb27a4cca429405a19e9de3ba593bbf1db63

commit 6967bd717dc0b3882686fe6162ef3f2cd52b23cf
Author: Thomas Bechtold <tbechtold@suse.com>
Date:   Fri Jun 10 10:29:42 2016 +0200

Remove discover from test-requirements
    
    It's only needed for python < 2.7 which is not supported
    
    Change-Id: Ic899f5f03e847c53c22dbe0b7ee02313648e4be8

commit 865bfec975b13f17a1351d70061e90a0dabfce1e
Author: Mehdi Abaakouk <sileht@redhat.com>
Date:   Tue Apr 5 16:08:51 2016 +0200

tests: rabbitmq failover tests
    
    This leverages the pifpaf library to exercice
    rabbitmq failover.
    
    Change-Id: Ic6acc5d006344e08c219724e488fc9222786d849

commit df9a0097a66160361e5fb753b2636d56fad4e982
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Fri Jul 1 07:58:08 2016 +0000

Imported Translations from Zanata
    
    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure
    
    Change-Id: I344d2a0c432927d6dde0208dc0682c36c8a85655

commit 6945323b34e76d9a2e5ffb64aef31594e755278b
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Thu Jun 30 18:48:25 2016 +0000

Updated from global requirements
    
    Change-Id: Ie47c04a5c439bd6303e50794909c2a81bc64e4d1

commit 861a3aceb20dc148b65620c771eff978440a60e9
Author: Mehdi Abaakouk <sileht@redhat.com>
Date:   Wed Jun 29 16:22:11 2016 +0200

Remove rabbitmq max_retries
    
    It was never clear was the purpose of this option.
    
    For the RPC API point of view raising MessageDeliveryFailure is kind
    of unexpected. For the Notification API, this is weird that when
    application put retry=-1, the lib stop to retry only with rabbit.
    
    So this change deprecates this option for removal.
    
    Change-Id: I4ac3a062426418276c96e1745d1c96a8525c36da

commit 61aae0ffacc346aba42f11c5a1c890bfa79c261f
Author: ChangBo Guo(gcb) <eric.guo@easystack.cn>
Date:   Tue Jun 28 15:47:39 2016 +0800

Config: no need to set default=None
    
    By default oslo.cfg sets the default value as None. There is no
    need to explicitly do this.
    
    TrivialFix
    
    Change-Id: I57fa9651ea56a180a910d6cbf7b7f385da8af239

commit dfd5c791c9fff06642e3cf80a09d6e918bef9938
Author: Gevorg Davoian <gdavoian@mirantis.com>
Date:   Wed Jun 8 14:05:14 2016 +0300

[zmq] Fix message sending when using proxy and not using PUB/SUB
    
    This patch fixes the problem of sending messages in the following
    configuration: use_router_proxy=True and use_pub_sub=False. Right
    now we have incorrect both cast and fanout messages: cast acts as
    fanout (instead of round-robin) and fanout duplicate each message
    twice.
    
    Change-Id: I2b039aa462ddde300fd50b3754e4fe66abf6e635

commit 3316edb2ea13ceb7640ec6168e74bfafb39795c9
Author: Kenneth Giusti <kgiusti@gmail.com>
Date:   Sun Jun 12 19:36:06 2016 -0400

AMQP 1.0 - create only one Cyrus SASL configuration for the tests
    
    The Cyrus SASL library can only be initialized once per process. And
    the configuration must remain available until all the tests have run.
    
    Change-Id: I2810ecf53956fc5d4fcdc944f8e06237ca985e6a
    Closes-Bug: #1591211

commit 5afb60512a21d116c09b176a61a59ff5b925d435
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Tue Jun 14 21:09:44 2016 +0000

Updated from global requirements
    
    Change-Id: I0cc8324da21fa246c936685048782ad2c2a94368

commit eb02de82233eff0a63708bf6608af22ee91d8ba8
Author: Gevorg Davoian <gdavoian@mirantis.com>
Date:   Wed Jun 8 13:02:22 2016 +0300

[zmq] Remove redundant Envelope class
    
    Change-Id: Ia5f28fab6fa3baeb4f4c48ff6019df128cef042b
    Partial-Bug: #1582207

commit 33c3f16f0101ae3ef9966f9188bff2429d0d76d8
Author: ozamiatin <ozamiatin@mirantis.com>
Date:   Mon Jun 13 16:43:59 2016 +0300

[zmq] Properly stop ZmqServer
    
    Each service being stopped should become
    invisible for clients. For zmq listener that
    means to cleanup it's redis target record
    and stop updating it.
    
    Starting of all consumers happen in init method.
    
    Change-Id: Icd2d2fc73871de1d4845280432f5dec9eab8d381
    Closes-Bug: #1590000

commit e57afac0511cb6bca94ab1964f5f669c56393e7a
Author: liusheng <liusheng@huawei.com>
Date:   Mon Jun 13 16:32:37 2016 +0800

[Trival] fix a typo nit
    
    Change-Id: I3d40726cf55aedb838ebe605f3d58618d594acca

commit d8b6bb0884fcb1145c57a780543a0b7fe65a3a52
Author: Oleksii Zamiatin <ozamiatin@mirantis.com>
Date:   Tue Jun 7 16:56:10 2016 +0300

[zmq] Fix backend router port for proxy.
    
    Incorrect value caused proxy to work only on FE socket.
    
    Change-Id: I3dcb5eb654c2597d26c8edffcc577dc88660b577

commit dc1309a003cb1059101294c4c74dd75e9c326f7d
Author: Kirill Bespalov <kbespalov@mirantis.com>
Date:   Tue May 24 20:45:52 2016 +0300

Improve the impl_rabbit logging
    
    It would be better if we could log a client port and some additional
    information about a connection, to understand where is problems occurs.
    The client port especially helpful for associating events in a rabbitmq.log
    with oslo.messaging logs.
    
    Change-Id: I0dae619f5a1688fb2f64fd90623fde2444609f04

tags:

added: in-feature-amqp-dispatch-router

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-08-18: Fix included in openstack/oslo.context 2.9.0

#21

This issue was fixed in the openstack/oslo.context 2.9.0 release.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-08-18: Fix included in openstack/oslo.db 4.12.0

#22

This issue was fixed in the openstack/oslo.db 4.12.0 release.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-08-18: Fix included in openstack/oslo.i18n 3.9.0

#23

This issue was fixed in the openstack/oslo.i18n 3.9.0 release.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-08-18: Fix included in openstack/oslo.middleware 3.18.0

#24

This issue was fixed in the openstack/oslo.middleware 3.18.0 release.

Haifeng.Yan (yanheven) on 2016-08-19

Changed in oslo.context:
status:	New → Fix Released
Changed in oslo.middleware:
status:	New → Fix Released
Changed in oslo.i18n:
status:	New → Fix Released
Changed in oslo.db:
status:	Confirmed → Fix Released