got an unexpected keyword argument 'encoding'

[Herve Beraud]

On train we got the following error.

We think it's due to msgpack 1.0.0 version incompatibility. I think we should backport [1] which is only available from oslo.privsep since ussuri.

/var/log/containers/neutron/privsep-helper.log

    repeating:
    2020-10-09 07:30:27.799 403686 CRITICAL privsep [-] Unhandled error: TypeError: __init__() got an unexpected keyword argument 'encoding'
    2020-10-09 07:30:27.799 403686 ERROR privsep Traceback (most recent call last):
    2020-10-09 07:30:27.799 403686 ERROR privsep File "/bin/privsep-helper", line 10, in <module>
    2020-10-09 07:30:27.799 403686 ERROR privsep sys.exit(helper_main())
    2020-10-09 07:30:27.799 403686 ERROR privsep File "/usr/lib/python3.6/site-packages/oslo_privsep/daemon.py", line 574, in helper_main
    2020-10-09 07:30:27.799 403686 ERROR privsep channel = comm.ServerChannel(sock)
    2020-10-09 07:30:27.799 403686 ERROR privsep File "/usr/lib/python3.6/site-packages/oslo_privsep/comm.py", line 189, in __init__
    2020-10-09 07:30:27.799 403686 ERROR privsep self.reader_iter = iter(Deserializer(sock))
    2020-10-09 07:30:27.799 403686 ERROR privsep File "/usr/lib/python3.6/site-packages/oslo_privsep/comm.py", line 69, in __init__
    2020-10-09 07:30:27.799 403686 ERROR privsep unicode_errors='surrogateescape')
    2020-10-09 07:30:27.799 403686 ERROR privsep File "msgpack/_unpacker.pyx", line 317, in msgpack._cmsgpack.Unpacker.__init__
    2020-10-09 07:30:27.799 403686 ERROR privsep TypeError: __init__() got an unexpected keyword argument 'encoding'
    2020-10-09 07:30:27.799 403686 ERROR privsep

[1] https://github.com/openstack/oslo.privsep/commit/f19765c683ce847f8d0ae0499d9e67c41114c0b7

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/757033

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/757033
Committed: https://git.openstack.org/cgit/openstack/oslo.privsep/commit/?id=ced0e7b33b617fbfd9137cf2917ab279092dbd7f
Submitter: Zuul
Branch: stable/train

commit ced0e7b33b617fbfd9137cf2917ab279092dbd7f
Author: Ben Nemec <email address hidden>
Date: Tue Mar 17 17:28:58 2020 +0000

    Make compatible with msgpack 1.0.0

    There are a couple of things that changed in msgpack 1.0.0 that were
    breaking oslo.privsep:

    1) The encoding parameter to Unpacker was removed. This has been
       deprecated for a while in favor of the `raw` parameter[0], so this
       change switches to using raw.

    2) The strict_map_key parameter default was changed from False to
       True.[1] I haven't found an explanation of why this was done, but
       we can explicitly set it False to maintain the previous behavior.

    Closes-Bug: 1855914
    Closes-Bug: 1864811
    0: https://msgpack-python.readthedocs.io/en/latest/api.html#msgpack.Unpacker
    1: https://github.com/msgpack/msgpack-python/pull/392/commits/6e1d12c0a2072572890cbb124b94cb08b582dd2d

    Change-Id: Ia97ecf965d807f12524d5b6602446934b5813ce6
    Closes-Bug: 1899140
    (cherry picked from commit f19765c683ce847f8d0ae0499d9e67c41114c0b7)