policy file in policy.d will be reloaded every rest api call

Bug #1437992 reported by Eli Qiao
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Invalid
Low
Eli Qiao
oslo.policy
Fix Released
Critical
Eli Qiao
Kilo
Fix Released
High
Doug Hellmann

Bug Description

the policy file in policy.d will be reloaded every time when do a rest api call.

Eli Qiao (taget-9)
Changed in nova:
assignee: nobody → Eli Qiao (taget-9)
Revision history for this message
Eli Qiao (taget-9) wrote :

by checking code, we pass overwrite=False

                self._walk_through_policy_directory(path,
                                                    self._load_policy_file,
                                                    force_reload, False)

so _load_policy_file will reload the policy every time.

Changed in nova:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/168784

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
Eli Qiao (taget-9) wrote :
Changed in oslo.policy:
status: New → Confirmed
assignee: nobody → Eli Qiao (taget-9)
Eli Qiao (taget-9)
Changed in oslo-incubator:
assignee: nobody → Eli Qiao (taget-9)
status: New → In Progress
Changed in oslo.policy:
importance: Undecided → Low
Changed in nova:
importance: Undecided → Low
Changed in oslo-incubator:
importance: Undecided → Low
Revision history for this message
Sean Dague (sdague) wrote :

raising this bug to critical in oslo, this causes an additional 33,000 policy file parses during a gate run in nova-api alone.

Changed in oslo-incubator:
importance: Low → Critical
Changed in oslo.policy:
importance: Low → Critical
Revision history for this message
Thomas Bechtold (toabctl) wrote :

Fix seems to be merged with https://review.openstack.org/#/c/169535/

Eli Qiao (taget-9)
Changed in oslo.policy:
status: Confirmed → Fix Committed
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

We need to back-port this change to the stable/kilo branch of oslo.policy and cut a release from there before anyone will see the fix.

Changed in oslo.policy:
milestone: none → next-liberty
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

The kilo backport patch is https://review.openstack.org/170863

Thierry Carrez (ttx)
no longer affects: oslo.policy/liberty
no longer affects: oslo-incubator
Changed in oslo.policy:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Eli Qiao (<email address hidden>) on branch: master
Review: https://review.openstack.org/168784
Reason: hope some one else have good propose

Revision history for this message
Eli Qiao (taget-9) wrote :

Nova reverts it to not use policy.d.
Sean doesn't agree to sync code from oslo.policy.
Then how to go in nova side.

Changed in nova:
status: In Progress → Incomplete
Revision history for this message
Sean Dague (sdague) wrote :

This is addressed via oslo.policy

Changed in nova:
status: Incomplete → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslo.policy 0.3.2

This issue was fixed in the openstack/oslo.policy 0.3.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.